-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack: New second lesson after Project Restaurant Page #27962
Webpack: New second lesson after Project Restaurant Page #27962
Conversation
Co-authored-by: advait0603 <[email protected]>
Content now moved to the new second Webpack lesson
Forgot that the first webpack lesson rewrite has a round up section which this was basically a duplicate of. The exact contents better suits how it's placed in the first lesson, so this lesson's one is to be removed.
Question for any reviewers: What's your opinion on also mentioning Considerations:
Right now, I feel it's valuable to mention it here after npm scripts and before webpack modes. |
Dang... that's a lot of words. 👀 |
Follows lesson file structure as prescribed by our style guide. Some resources from the main contents have been moved to assigned reading. Removed "JavaScript Linters" resource due to duplicate information, and it also makes an explicit recommendation that differs from our lesson contents, which can cause confusion.
More consistent with "Linting" section, as opposed to "ESLint" section. Prettier installation guide added to be more consistent with ESLint links in the Linting section. Knowledge check questions amended to account for this change. Capitalisation nits.
Fixed descriptive link text for ESLint
Added Some minor section content changes have also been made to accommodate the structure change. |
GitHub outage leading to stalled workflows which were aborted. Unable to manually trigger otherwise.
It's both a relevant tip for the lesson, and it helps reduce confusion caused by moving the template repos section to a lesson more than one lesson back (in case someone was at, say, the To-do list project when these changes get merged).
Co-authored-by: Jack Bogart <[email protected]>
Use more assertive wording
Regarding The original idea was that it would help explain why we import CSS instead of just linking the stylesheet in the HTML template and using Not really necessary here, I think. Opens too many doors to rabbit holes (e.g. to combine multiple CSS file imports into 1, you'd need to set up a bunch of optimisation properties in the config too). I think all we'd need is the rewritten Webpack tutorial to just mention "most build tools do a little more than this, but this is enough to allow us to get used to importing CSS files in your JS", since that'll be more important in the React course with Vite, where Vite handles all the CSS loading for you. End waffle |
Grammar fix, and slight softening of the intro to style guides. People have mistakenly thought they had to read all style guides top to bottom like novels and memorise all the information there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
Because
The current Webpack lesson is a known pain point in the curriculum journey, primarily due to the sudden increase in complexity and steps of tooling, coupled with how much of the learning is left to external resources. These external resources limit the cohesiveness of teaching material, and can prove troublesome in the learning process when each resource includes a few unnecessary tidbits that can easily throw learners off (such as multiple entry points in the webpack official guides when learning about html-webpack-plugin). They also are frequently aimed at people who may know a little more about bundlers already, or are following a different course/tutorial. Thus, things often feel disjointed with the TOP curriculum.
While improving the Webpack lesson itself is the primary focus, it was also identified that the preceding ES6 modules lesson is fairly coupled with it, as Webpack and bundlers are introduced there instead of the Webpack lesson.
The order of the ES6 modules lesson was also identified as a little odd, and the order and flow could be improved by focusing on ES6 modules as a primary topic straight away, then introducing bundlers and Webpack in their own separate lesson.
General plan:
This PR
Issue
Related to #26976
Related to #26977
(closed by #27953)
Additional Information
This will be something to merge alongside 3 other PRs:
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section