Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Linting: Remove "use flat config" setting mention #28405

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Jul 14, 2024

Because

As of release v3.0.8 of the ESLint VSC extension, it applies the appropriate setting for "useFlatConfig" based on the detected ESLint package version in the open workspace. No need to manually override in this situation (which requires editing settings.json now, instead of a checkbox in settings).

This PR

  • Removes mention of manually setting useFlatConfig value.
  • Changes project to workspace to better reflect the extension's current behaviour.

Issue

N/A

Additional Information

Yet another recent change with the whole ESLint situation...

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

As of release v3.0.8, the extension applies the appropriate setting
for "useFlatConfig" based on the detected ESLint package version in the
open workspace. No need to manually override in this situation.
@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Jul 14, 2024
@MaoShizhong
Copy link
Contributor Author

Lint error can be ignored as it'll be fixed in #27962

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MaoShizhong MaoShizhong merged commit 9a3d516 into TheOdinProject:main Jul 15, 2024
3 of 4 checks passed
@MaoShizhong MaoShizhong deleted the chore/remove-outdated-eslint-setting branch July 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants