Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Linting: Remove release version-specific note box #28289

Merged

Conversation

MaoShizhong
Copy link
Contributor

Because

ESLint's VSCode extension's release version has now been updated to resolve the issue that one of the Linting lesson's note boxes addresses - now v3.0.10 as of this PR.

The v9 support note box also needs to specify that the Eslint: Use Flat Config setting must be disabled if someone follows that step, else it won't recognise the old eslintrc format.

This PR

  • Removes version-specific note box for ESLint's VSCode extension
  • Specifies enabling Eslint: Use Flat Config in the main ESLint extension instructions
  • Specifies disabling Eslint: Use Flat Config in the v9 support note box

Issue

N/A

Additional Information

I really look forward to when ESLint v9 and flat config is widely supported among the community plugins...

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

ESLint VSCode extension release version now updated and fixes the issue.
Also specified `Use Flat Config` VSCode setting for relevant ESLint
config formats.
@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Jun 27, 2024
@MaoShizhong
Copy link
Contributor Author

The linting error is from a missing assignment section. I'll address it as part of the ESM/Webpack rewrite PRs, as that also involves moving template repos away from the lesson.

@CouchofTomato
Copy link
Member

There is a linting issue which I'm not sure whether it needs to be addressed. Otherwise it's fine.

@MaoShizhong
Copy link
Contributor Author

Thanks @CouchofTomato. As per the above comment, I'll address the lint issue in #27962 in due course due to more relevant changes there.

@MaoShizhong MaoShizhong merged commit 8c7a0ba into TheOdinProject:main Jun 28, 2024
3 of 4 checks passed
@MaoShizhong MaoShizhong deleted the chore/js-linting-eslint-extension branch June 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants