generated from Team488/FRCRobotTemplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PrepareToScoreInAmpCommand #77
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
23a31fd
add PrepareToScoreInAmpCommand
j0ndough f831cdc
Merge branch 'main' into PrepareToScoreInAmpCommand
j0ndough 88950c5
add generic function to set arm and shooter
j0ndough ffcb2ba
Merge branch 'PrepareToScoreInAmpCommand' of github.com:Team488/XBot2…
j0ndough 19002fa
Merge branch 'main' of github.com:Team488/XBot2024 into PrepareToScor…
j0ndough 2a5b191
create command group to set arm and shooter rpm
j0ndough 43f2882
rename to be amp specific command group
j0ndough 0e476e5
Merge branch 'main' into PrepareToScoreInAmpCommand
j0ndough File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ I wonder if there's a way we could unify the position -> angle + rpm logic so you can have a single command that's about preparing for an arbitary position that does both? What do you think?
Since very soon we'll have a bunch of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a generic helper function that sets arm position and shooter wheel rpm.