-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PrepareToScoreInAmpCommand #77
Conversation
) | ||
{ | ||
// Prepare to score in Amp | ||
armAngle.setArmPosition(ArmSubsystem.UsefulArmPosition.FIRING_IN_AMP); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ I wonder if there's a way we could unify the position -> angle + rpm logic so you can have a single command that's about preparing for an arbitary position that does both? What do you think?
Since very soon we'll have a bunch of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a generic helper function that sets arm position and shooter wheel rpm.
…024 into PrepareToScoreInAmpCommand
Why are we doing this?
Sets up the robot to allow it to score a note in the amp.
Asana task URL:
https://app.asana.com/0/38541457243752/1206397655151703
Whats changing?
Added placeholder RPM property in ShooterWheelSubsystem to be scored in the amp.
Added PrepareToScoreInAmp command in OperatorCommandMap to prepare arm and shooter wheels to score in amp.
Questions/notes for reviewers
How this was tested