Create PrepareToScoreInAmpCommand #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
approved these changes
Feb 3, 2024
| ) | ||
| { | ||
| // Prepare to score in Amp | ||
| armAngle.setArmPosition(ArmSubsystem.UsefulArmPosition.FIRING_IN_AMP); |
There was a problem hiding this comment.
⭐ I wonder if there's a way we could unify the position -> angle + rpm logic so you can have a single command that's about preparing for an arbitary position that does both? What do you think?
Since very soon we'll have a bunch of these
There was a problem hiding this comment.
added a generic helper function that sets arm position and shooter wheel rpm.
…024 into PrepareToScoreInAmpCommand
aschokking
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Sets up the robot to allow it to score a note in the amp.
Asana task URL:
https://app.asana.com/0/38541457243752/1206397655151703
Whats changing?
Added placeholder RPM property in ShooterWheelSubsystem to be scored in the amp.
Added PrepareToScoreInAmp command in OperatorCommandMap to prepare arm and shooter wheels to score in amp.
Questions/notes for reviewers
How this was tested