Feature/drive to given note with bearing vision #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschokking
reviewed
Mar 31, 2024
src/main/java/competition/operator_interface/OperatorCommandMap.java
Outdated
Show resolved
Hide resolved
| double terminalPower = approachPower * 0.5; | ||
| // If we are doing vision stuff, then we need to use robot-relative driving. | ||
| // When approaching dynamically, drive pretty fast and keep pointing at the note. | ||
| if (noteAcquisitionMode == NoteAcquisitionMode.VisionApproach) { |
There was a problem hiding this comment.
⭐ I wonder if we shouldn't drive too fast until the yaw error is small enough?
…nd on smart dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Updates our auto to use a new approach to vision using the center camera
Asana task URL:
Whats changing?
Questions/notes for reviewers
How this was tested