Feature/shooter dynamic error ranges #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle and back again (nonlinear) Implement getArmAngleForExtension(), convert extension distance to angle and back again (nonlinear) 2/22
stephenjust
approved these changes
Feb 24, 2024
stephenjust
approved these changes
Feb 24, 2024
aschokking
approved these changes
Feb 24, 2024
| @@ -315,7 +315,7 @@ public void setupAdvancedOperatorCommands( | |||
| oi.operatorGamepadAdvanced.getXboxButton(XboxButton.Y).whileTrue(prepareToFireAtAmp); | |||
| oi.operatorGamepadAdvanced.getXboxButton(XboxButton.A).whileTrue(continuouslyPrepareToFireAtSpeaker); | |||
|
|
|||
| oi.operatorGamepadAdvanced.getXboxButton(XboxButton.RightTrigger).whileTrue(fireWhenReady); | |||
| oi.operatorGamepadAdvanced.getXboxButton(XboxButton.RightTrigger).whileTrue(fireWhenReady.repeatedly()); | |||
There was a problem hiding this comment.
⭐ I think we might want a different version of this command that doesn't end (and just keeps shooting steadily instead), I'm a little worried the repeatedly will be confusing with the current isFinished logic and shooting for a min time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
The shooter wheels can take a long time to get up to speed - and we probably don't need full power for SUBWOOFER or AMP shots.
Asana task URL:
Whats changing?
When the arm is all the way down, or raised high up, we accept a larger RPM error.
Questions/notes for reviewers
How this was tested