Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First wave of basic fixes against real robot #104

Merged
merged 8 commits into from
Feb 18, 2024
Merged

First wave of basic fixes against real robot #104

merged 8 commits into from
Feb 18, 2024

Conversation

JohnGilb
Copy link
Contributor

Why are we doing this?

Initial burn-in test of robot
Asana task URL:

Whats changing?

  • Systems now mark as ready
  • Use correct electrical contract values
  • If nothing using the shooter, stop it
  • Bugfix in asymmetric arm balance code
  • Use better deadband in manual arm mode
  • Default shooter PID values, short-term hack to ensure P/F updated at launch

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@JohnGilb JohnGilb requested a review from a team as a code owner February 18, 2024 19:21
@JohnGilb JohnGilb changed the title Feature/make robot work First wave of basic fixes against real robot Feb 18, 2024
@JohnGilb JohnGilb merged commit a7ba612 into main Feb 18, 2024
1 check passed
@JohnGilb JohnGilb deleted the feature/MakeRobotWork branch February 18, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschokking aschokking aschokking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnGilb @aschokking