-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FAD/Oxygen-Peroxide Duplicate Reactions #670
Conversation
…tions that contained O2 and H2O2
@feiranl @haowang-bioinfo when I initially made this PR, it passed all of the metabolic task checks, but when I merged in the latest develop branch just now, it failed the "verification" tasks, but the error message doesn't give me enough details to follow up on what exactly is causing that issue, so I'm not sure how to proceed. (no rush to answer, since I know I've opened a bunch of issues and PRs recently, but just flagging that I don't know how to respond to this test failing) |
will manually check what specific task(s) are affected by this PR, which appears to involve over amount of changes |
remove rows 'MAR01639', 'MAR01635', 'MAR01637', 'MAR01653', 'MAR01656' from "reactions.tsv"
manual check located that the step of "reverse MAR00059 and remove 0.5 O2" (commit 9d7b81c) caused the failure in checking verification tasks. Specifically, it allows:
these tasks suppose to fail for a mass and energy balanced model |
Good catch, @haowang-bioinfo. The removal of the 0.5 O2 in that reaction resulted in it becoming mass-imbalanced, and reversing the reaction led to a thermodynamically infeasible reaction. For example, a loop could be formed with reaction MAR01706:
Even without O2, it allows water to reduce FAD, which is incorrect. With O2, it allows the same reduction, but also produces O2 from water, which is also problematic. @Devlin-Moyer, what was your justification for reversing and removing O2 from MAR00059? It seems to me that neither of those changes should be made. |
From #639:
I was just thinking about redox when putting together this issue, and since every other reaction on this list was straightforward redox, it never occurred to me to check the empirical formulas of these metabolites to figure out if the 0.5 O2 was necessary; I stand by my initial claim that the original form of |
Hmm apparently if you remove the 0.5 O2 from the original reaction, it exactly matches R04547, but KEGG doesn't associate that with any human enzymes, so do we know if this reaction happens in humans at all? Does removing it create a gap? |
I also found (24R,25R)3alpha,7alpha,24-trihydroxy-5beta-cholestanoyl-CoA in the primary bile acid biosynthesis KEGG pathway (near the bottom left, directly above chenodeoxycholate), where it participates in two reactions already represented by Now that I look at
I think the situation is that |
so the change made to MAR00059 is based on KEGG, which actually is known with rich amount of unbalanced reactions. Genes associate with R04547 all appear to be from bacterial kingdom.
it's confirmed that removal of MAR00059 could fix aforementioned failures (allows water to reduce FAD, produces O2 from water) in verification tasks |
Thanks for the thorough update, @Devlin-Moyer. I agree that removing MAR00059 seems like a good solution, and thank you @haowang-bioinfo for verifying. |
should the GPR of MAR01706 be modified, and how? |
Based on the research I did in #634 and #637, the GPR of |
@Devlin-Moyer which Rhea reaction could be associated with MAR01706? |
Pretty sure it's 47408/47409 |
will update Rhea id for MAR01706 in #707 |
- update Rhea ids as mentioned in #670
Main improvements in this PR:
As proposed in #639:
MAR00059
for being a less accurate version ofMAR01706
MAR01706
toENSG00000113790 or ENSG00000133835
and addsPMID:19357427
to its referencesMAR01639
for being redundant withMAR01638
MAR03301
for being redundant withMAR02804
MAR03306
for being redundant withMAR02808
MAR03311
for being redundant withMAR02810
MAR04966
for being redundant withMAR02818
MAR03364
for being redundant withMAR03276
MAR03369
for being redundant withMAR03289
MAM02630x
(O2) withMAM01802x
(FAD) andMAM02041x
(H2O2) withMAM01803x
(FADH2) inMAR00442, MAR00759, MAR00777, MAR00800, MAR00833, MAR00872, MAR00952, MAR00968, MAR00974, MAR00975, MAR00977, MAR00978, MAR00982, MAR01001, MAR01005, MAR01018, MAR01162, MAR01205, MAR01254, MAR01271, MAR01291, MAR01296, MAR01303, MAR01600, MAR01704, MAR02408, MAR02510, MAR03053, MAR03054, MAR03055, MAR03056, MAR03057, MAR03062, MAR03066, MAR03070, MAR03074, MAR03078, MAR03082, MAR03086, MAR03090, MAR03094, MAR03098, MAR03102, MAR03326, MAR03330, MAR03334, MAR03338, MAR03342, MAR03346, MAR03350, MAR03356, MAR03360, MAR03459, MAR03466, MAR03470, MAR03498, MAR03506, MAR03512, MAR03849, MAR03984, MAR04001, MAR04650, MAR04789, MAR04981, MAR05025, MAR05026, MAR05028, MAR05097, MAR05100, MAR05108, MAR05119, MAR05175, MAR05178, MAR05180, MAR05182, MAR05184, MAR05189, MAR05196, MAR05300, MAR05327, MAR05331, MAR05350, MAR05366, MAR05372, MAR05374, MAR05377, MAR05382, MAR05421, MAR05428, MAR05431, MAR06284, MAR06285, MAR06322, MAR06344, MAR06345, MAR06933, MAR06936, MAR06943, MAR06946, MAR06949, MAR06952, MAR06959, MAR06962, MAR06964, MAR07641, MAR07647, MAR07704, MAR07706, MAR08017, MAR08021, MAR08415, MAR08689, MAR08690, MAR08755, MAR11529, MAR11534, MAR11539, MAR12372, MAR12808
, andMAR20066
MAR20114
to represent reduction of O2 by FADH2:MAM02630x + MAM01803x -> MAM02041x + MAM01802x
, GPR:ENSG00000161533 or ENSG00000168306 or ENSG00000087008 or ENSG00000110887 or ENSG00000203797 or ENSG00000007171 or ENSG00000148832 or ENSG00000179761 or ENSG00000158125
, reference:PMID:30378035
I hereby confirm that I have:
develop
as a target branch