-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Peroxisomal Cofactor Transport Reactions #701
Conversation
I can't figure out why the YAML conversion checks are failing; I feel like that's usually due to a formatting issue where like I didn't indent a particular line right or misspelled one of the field names, but I keep failing to see any of those kinds of typos. |
yes there are formatting issues that should be due to the missing "eccodes" fields from MAR20117 onward I wonder how did you output the yaml file, which function did you use? @Devlin-Moyer |
aha thanks for spotting that; I'll fix it when I get back to my computer also I've been editing it directly with a text editor cuz I don't know Matlab and found out the hard way that Cobrapy doesn't output YAML files in this exact format and it seemed easier (if more tedious) to just do it by hand than figure out what changes I'd need to make Cobrapy's yaml output |
editing directly with a text editor is fine but not optimal way, which might end up with something mentioned in #558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job!
@Devlin-Moyer great job! a small thing: MAR20117 is not fully balanced - now fixed in 3eb0817 @feiranl probably at some point it's good to have a mass/charge balance check for new reactions? |
Yes, I totally agree. A new issue has been opened to address this. |
ah thanks for catching that. and yea, incorporating that into the automated checks would be very useful, because it's easy to miss a few protons like I did here, and #670 would've been way easier to resolve if one of the automated checks had told us that one of those edits un-balanced a reaction |
Main improvements in this PR:
As proposed in #640:
MAR07785
for being a less accurate/complete duplicate ofMAR04908
MAR07775
because there's no evidence that NADH is transported across the peroxisomal membraneMAR07788
because there’s no evidence that FADH2 is transported across the peroxisomal membraneMAR04915
,MAR07771
,MAR07782
,MAR07783
, andMAR07790
because the only known peroxisomal transporters of those metabolites catalyze antiport, not uniportMAR03473
to be ADP [c] + AMP [x] <-> ADP [x] + AMP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20115
: AMP [c] <-> AMP [x], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20116
: ADP [c] <-> ADP [x], GPR:ENSG00000100372
, reference:PMID:22185573
MAM01828x
MAR20117
: FAD [x] + H2O [x] -> FMN [x] + AMP [x], GPR:ENSG00000112874
, reference:PMID:22185573
MAR20118
: FMN [c] + CoA [x] <-> FMN [x] + CoA [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20119
: FMN [c] + FAD [x] <-> FMN [x] + FAD [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20120
: FMN [c] + NAD+ [x] <-> FMN [x] + NAD+ [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20121
: FMN [c] + AMP [x] <-> FMN [x] + AMP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20122
: FMN [c] + ADP [x] <-> FMN [x] + ADP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20123
: FAD [c] + CoA [x] <-> FAD [x] + CoA [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20124
: FAD [c] + NAD+ [x] <-> FAD [x] + NAD+ [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20125
: FAD [c] + AMP [x] <-> FAD [x] + AMP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20126
: FAD [c] + ADP [x] <-> FAD [x] + ADP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20127
: NAD+ [c] + CoA [x] <-> NAD+ [x] + CoA [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20128
: NAD+ [c] + AMP [x] <-> NAD+ [x] + AMP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20129
: NAD+ [c] + ADP [x] <-> NAD+ [x] + ADP [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20130
: AMP [c] + CoA [x] <-> AMP [x] + CoA [c], GPR:ENSG00000100372
, reference:PMID:22185573
MAR20131
: ADP [c] + CoA [x] <-> ADP [x] + CoA [c], GPR:ENSG00000100372
, reference:PMID:22185573
I hereby confirm that I have:
develop
as a target branch