Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge MAR08973 into MAR04474 #365

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

mihai-sysbio
Copy link
Member

Main improvements in this PR:

As per the suggestion in #346, MAR08973 was merged into MAR04474.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

@JonathanRob
Copy link
Collaborator

Ah crap, I broke it. I think it's failing the check now because I added a reaction to deprecatedReactions.tsv (to reconcile conflict with develop), but the reaction hasn't actually yet been deleted from the model/annotation files in this branch...

@JonathanRob
Copy link
Collaborator

Update: Crisis. Averted.

@JonathanRob JonathanRob merged commit 946ed63 into develop Mar 4, 2022
@JonathanRob JonathanRob deleted the refactor/merge-MAR08973-into-MAR04474 branch March 4, 2022 18:05
@JonathanRob JonathanRob mentioned this pull request Mar 4, 2022
3 tasks
@mihai-sysbio mihai-sysbio mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants