-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicates #346
Comments
NIcely spotted @johan-gson! How did you find these duplicates? Do you think the detection can be scripted? |
Yeah, I found this doing some script, while working on speeding up tINIT. So, this can be scripted. |
@johan-gson I hope it's okay that I've edited the issue: the second pair of reactions didn't have the exact same GPRs, so I moved it into #348. This way we can resolve at least the straightforward part of this issue sooner. |
Very okay, no worries :) |
Resolved with #365 |
Description of the issue:
These reactions are duplicates, they have the same GPR:
MAR04474: {'6-phospho-D-gluconate[c] + NADP+[c] => CO2[c] + NADPH[c] + ribulose-5-phosphate[c]' }
MAR08973: {'3 6-phospho-D-gluconate[c] + 3 NADP+[c] => 3 CO2[c] + 3 NADPH[c] + 3 ribulose-5-phosphate[c]'} (remove this one)
These reactions could be joined into a reversible rxn to avoid loops, they have the same GPRs:moved into #348'MAR08482': {'3-oxotetradecanoyl-[ACP][c] + H+[c] + NADPH[c] => HMA[c] + NADP+[c]'}
'MAR02358': {'HMA[c] + NADP+[c] => 3-oxotetradecanoyl-[ACP][c] + H+[c] + NADPH[c]'}
I hereby confirm that I have:
main
branch of the repositoryThe text was updated successfully, but these errors were encountered: