[Feature] Support add/drop field for struct column(part1) #46451

sevev · 2024-05-30T06:31:15Z

Why I'm doing:

It is the first pr to support add/drop field for struct column.

What I'm doing:

The main changes in this PR are two fold:

Adding a unique ID to the fields in the struct column. Each field column can be uniquely identified by its name and ID.
When creating a column reader for the struct column, the corresponding reader will be created for each field based on the provided column.

Fixes #46452

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

be/src/storage/tablet_schema.h

be/src/storage/rowset/column_reader.h

Signed-off-by: zhangqiang <[email protected]>

be/src/storage/rowset/column_reader.h

be/src/storage/rowset/column_reader.cpp

Signed-off-by: sevev <[email protected]>

sonarcloud · 2024-06-14T07:06:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-06-14T09:20:39Z

[FE Incremental Coverage Report]

✅ pass : 8 / 8 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/StructField.java	8	8	100.00%	[]

github-actions · 2024-06-14T09:27:01Z

[BE Incremental Coverage Report]

✅ pass : 79 / 82 (96.34%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/storage/tablet_schema.h	5	6	83.33%	[167]
🔵	be/src/storage/rowset/column_reader.cpp	64	66	96.97%	[647, 648]
🔵	be/src/storage/rowset/column_reader.h	5	5	100.00%	[]
🔵	be/src/storage/rowset/segment.cpp	3	3	100.00%	[]
🔵	be/src/storage/metadata_util.cpp	2	2	100.00%	[]

sevev · 2024-06-17T09:10:46Z

@mergify backport branch-3.3

mergify · 2024-06-17T09:10:53Z

backport branch-3.3

✅ Backports have been created

#47109 [Feature] Support add/drop field for struct column(part1) (backport #46451) has been created for branch branch-3.3

sevev · 2024-06-17T09:10:58Z

@mergify backport branch-3.2

mergify · 2024-06-17T09:11:04Z

backport branch-3.2

✅ Backports have been created

#47110 [Feature] Support add/drop field for struct column(part1) (backport #46451) has been created for branch branch-3.2 but encountered conflicts

Signed-off-by: zhangqiang <[email protected]> Signed-off-by: sevev <[email protected]> (cherry picked from commit 757f142)

Signed-off-by: zhangqiang <[email protected]> Signed-off-by: sevev <[email protected]> (cherry picked from commit 757f142) # Conflicts: # be/src/storage/rowset/column_reader.cpp # be/src/storage/rowset/column_reader.h # be/src/storage/rowset/segment.cpp # be/test/storage/rowset/flat_json_column_rw_test.cpp # be/test/storage/rowset/struct_column_rw_test.cpp

…46451) (#47109) Co-authored-by: zhangqiang <[email protected]>

sevev · 2024-06-27T02:15:17Z

@mergify backport branch-3.2

mergify · 2024-06-27T02:15:23Z

backport branch-3.2

✅ Backports have been created

#47110 [Feature] Support add/drop field for struct column(part1) (backport #46451) has been created for branch branch-3.2

…46451) (#47110) Signed-off-by: sevev <[email protected]> Co-authored-by: zhangqiang <[email protected]>

sevev requested review from a team as code owners May 30, 2024 06:31

wanpengfei-git added META-REVIEW PROTO-REVIEW labels May 30, 2024

wanpengfei-git requested review from a team May 30, 2024 06:31

mergify bot assigned sevev May 30, 2024

imay reviewed May 30, 2024

View reviewed changes

be/src/storage/tablet_schema.h Show resolved Hide resolved

be/src/storage/rowset/column_reader.h Show resolved Hide resolved

be/src/storage/rowset/column_reader.h Show resolved Hide resolved

wyb requested review from wyb and luohaha June 7, 2024 02:09

sevev added 4 commits June 12, 2024 09:57

support create column iterator with TabletColumn

de319af

Signed-off-by: zhangqiang <[email protected]>

update

82a1b15

Signed-off-by: zhangqiang <[email protected]>

update

8019e50

Signed-off-by: zhangqiang <[email protected]>

Add some comment

7e5bc58

Signed-off-by: zhangqiang <[email protected]>

sevev force-pushed the support_add_drop_field_part1 branch from b6bb230 to 7e5bc58 Compare June 12, 2024 01:57

wyb reviewed Jun 13, 2024

View reviewed changes

be/src/storage/rowset/column_reader.h Outdated Show resolved Hide resolved

be/src/storage/rowset/column_reader.cpp Show resolved Hide resolved

be/src/storage/rowset/column_reader.cpp Show resolved Hide resolved

update

fad0c21

Signed-off-by: sevev <[email protected]>

wyb previously approved these changes Jun 13, 2024

View reviewed changes

sevev added 2 commits June 14, 2024 11:07

add default construct function

43a061c

Signed-off-by: sevev <[email protected]>

update

bae24dd

Signed-off-by: sevev <[email protected]>

sevev dismissed wyb’s stale review via bae24dd June 14, 2024 06:42

gengjun-git approved these changes Jun 14, 2024

View reviewed changes

wyb approved these changes Jun 17, 2024

View reviewed changes

wyb enabled auto-merge (squash) June 17, 2024 02:12

tracymacding approved these changes Jun 17, 2024

View reviewed changes

HangyuanLiu approved these changes Jun 17, 2024

View reviewed changes

wyb merged commit 757f142 into StarRocks:main Jun 17, 2024
56 of 59 checks passed

github-actions bot added the version:3.4 label Jun 17, 2024

wanpengfei-git mentioned this pull request Jun 17, 2024

Support Add/drop Field for struct column #46452

Closed

11 tasks

mergify bot pushed a commit that referenced this pull request Jun 17, 2024

[Feature] Support add/drop field for struct column(part1) (#46451)

5c49bf9

Signed-off-by: zhangqiang <[email protected]> Signed-off-by: sevev <[email protected]> (cherry picked from commit 757f142)

mergify bot mentioned this pull request Jun 17, 2024

[Feature] Support add/drop field for struct column(part1) (backport #46451) #47109

Merged

42 tasks

mergify bot mentioned this pull request Jun 17, 2024

[Feature] Support add/drop field for struct column(part1) (backport #46451) #47110

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2024

[Feature] Support add/drop field for struct column(part1) (backport #…

edaf9f4

…46451) (#47109) Co-authored-by: zhangqiang <[email protected]>

github-actions bot added the 3.3-merged label Jun 17, 2024

wanpengfei-git pushed a commit that referenced this pull request Jun 27, 2024

[Feature] Support add/drop field for struct column(part1) (backport #…

33c4a74

…46451) (#47110) Signed-off-by: sevev <[email protected]> Co-authored-by: zhangqiang <[email protected]>

github-actions bot added the 3.2-merged label Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Support add/drop field for struct column(part1) #46451

[Feature] Support add/drop field for struct column(part1) #46451

sevev commented May 30, 2024 •

edited

Loading

sonarcloud bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 14, 2024

sevev commented Jun 17, 2024

mergify bot commented Jun 17, 2024 •

edited

Loading

sevev commented Jun 17, 2024

mergify bot commented Jun 17, 2024 •

edited

Loading

sevev commented Jun 27, 2024

mergify bot commented Jun 27, 2024

[Feature] Support add/drop field for struct column(part1) #46451

[Feature] Support add/drop field for struct column(part1) #46451

Conversation

sevev commented May 30, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Jun 14, 2024

Quality Gate passed

github-actions bot commented Jun 14, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Jun 14, 2024

[BE Incremental Coverage Report]

file detail

sevev commented Jun 17, 2024

mergify bot commented Jun 17, 2024 • edited Loading

✅ Backports have been created

sevev commented Jun 17, 2024

mergify bot commented Jun 17, 2024 • edited Loading

✅ Backports have been created

sevev commented Jun 27, 2024

mergify bot commented Jun 27, 2024

✅ Backports have been created

sevev commented May 30, 2024 •

edited

Loading

mergify bot commented Jun 17, 2024 •

edited

Loading

mergify bot commented Jun 17, 2024 •

edited

Loading