Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Add/drop Field for struct column #46452

Closed
11 tasks done
sevev opened this issue May 30, 2024 · 0 comments · Fixed by #46451, #46619, #47217 or #48430
Closed
11 tasks done

Support Add/drop Field for struct column #46452

sevev opened this issue May 30, 2024 · 0 comments · Fixed by #46451, #46619, #47217 or #48430
Assignees
@sevev
Labels
type/feature-request version:3.2.9 version:3.3.0 version:3.3.1 version:3.3.2 version:3.4

Comments

@sevev
Copy link
Contributor

sevev commented May 30, 2024 •
edited by wanpengfei-git
Loading

Feature request

Support add/drop field for struct column

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@sevev sevev mentioned this issue May 30, 2024
Merged
24 tasks
@sevev sevev self-assigned this Jun 3, 2024
@sevev sevev mentioned this issue Jun 4, 2024
Merged
24 tasks
This was referenced Jun 17, 2024
Merged
Merged
@sevev sevev closed this as completed in 93f333e Jun 19, 2024
mergify bot pushed a commit that referenced this issue Jun 19, 2024
@sevev @mergify
[Feature]Support add/drop field for struct column(part2) (#46619)
a48b7c8 
## Why I'm doing:
It is the second pr to support add/drop field for struct column.

## What I'm doing:
The main changes in this PR are two fold:

1. Add the new syntax for add/drop field.
2. Support analyze add/drop field.

This pr doesn't fully implement this feature yet, and will throw not support exception when executed.

Fixes #46452

Signed-off-by: zhangqiang <[email protected]>
(cherry picked from commit 93f333e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseVisitor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocksLex.g4
@mergify mergify bot mentioned this issue Jun 19, 2024
Merged
42 tasks
@sevev sevev mentioned this issue Jun 19, 2024
Merged
24 tasks
@mergify mergify bot mentioned this issue Jun 26, 2024
Merged
42 tasks
happut pushed a commit to happut/starrocks that referenced this issue Jun 26, 2024
@sevev @happut
[Feature]Support add/drop field for struct column(part2) (StarRocks#4…
eabfbc7 
…6619)

## Why I'm doing:
It is the second pr to support add/drop field for struct column. 

## What I'm doing:
The main changes in this PR are two fold:

1. Add the new syntax for add/drop field.
2. Support analyze add/drop field.

This pr doesn't fully implement this feature yet, and will throw not support exception when executed.

Fixes StarRocks#46452

Signed-off-by: zhangqiang <[email protected]>
mergify bot pushed a commit that referenced this issue Jun 27, 2024
@sevev @mergify
[Feature]Support add/drop field for struct column(part2) (#46619)
0d697b7 
## Why I'm doing:
It is the second pr to support add/drop field for struct column.

## What I'm doing:
The main changes in this PR are two fold:

1. Add the new syntax for add/drop field.
2. Support analyze add/drop field.

This pr doesn't fully implement this feature yet, and will throw not support exception when executed.

Fixes #46452

Signed-off-by: zhangqiang <[email protected]>
(cherry picked from commit 93f333e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergAlterTableExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseVisitor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocksLex.g4
This was referenced Jun 27, 2024
Merged
Merged
@andyziye andyziye closed this as completed Jul 2, 2024
@sevev sevev mentioned this issue Jul 16, 2024
Merged
24 tasks
@mergify mergify bot mentioned this issue Jul 31, 2024
Merged
42 tasks
@wangruin wangruin closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sevev sevev

Labels
type/feature-request version:3.2.9 version:3.3.0 version:3.3.1 version:3.3.2 version:3.4
Projects
None yet
Milestone
No milestone
2 participants
@sevev @wanpengfei-git