Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support add/drop filed for struct column in share-data mode #48430

Merged
merged 13 commits into from
Jul 30, 2024
Merged

[Feature] Support add/drop filed for struct column in share-data mode #48430

merged 13 commits into from
Jul 30, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Jul 16, 2024 •
edited
Loading

Why I'm doing:

Support add/drop field for struct column in shared-data mode.

What I'm doing:

Fixes #46452

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sevev sevev requested review from a team as code owners July 16, 2024 09:11
@wanpengfei-git wanpengfei-git requested a review from a team July 16, 2024 09:11
@mergify mergify bot assigned sevev Jul 16, 2024
@sevev sevev force-pushed the lake_add_drop_field branch 4 times, most recently from 3a7997a to 68ffb8e Compare July 17, 2024 06:16
@sevev sevev changed the title [WIP][Feature] Support add/drop filed for struct column in share-data mode [Feature] Support add/drop filed for struct column in share-data mode Jul 17, 2024
wyb
wyb reviewed Jul 24, 2024
View reviewed changes
be/src/storage/lake/horizontal_compaction_task.cpp Outdated Show resolved Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableClauseAnalyzer.java Outdated Show resolved Hide resolved
be/src/storage/lake/vertical_compaction_task.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/txn_log_applier.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/meta_file.cpp Outdated Show resolved Hide resolved
@sevev sevev force-pushed the lake_add_drop_field branch 2 times, most recently from 3d66a5d to 72a526f Compare July 25, 2024 12:30
@HangyuanLiu HangyuanLiu self-assigned this Jul 25, 2024
wyb
wyb reviewed Jul 26, 2024
View reviewed changes
gensrc/proto/lake_types.proto Outdated Show resolved Hide resolved
wyb
wyb reviewed Jul 29, 2024
View reviewed changes
be/src/storage/lake/tablet_manager.cpp Outdated Show resolved Hide resolved
gensrc/proto/lake_types.proto Outdated Show resolved Hide resolved
gensrc/proto/lake_types.proto Outdated Show resolved Hide resolved
be/src/storage/lake/meta_file.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/meta_file.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/meta_file.cpp Outdated Show resolved Hide resolved
sevev added 12 commits July 30, 2024 15:09
@sevev
support single rowset compaction with alter struct
ae67f17 
Signed-off-by: sevev <[email protected]>
@sevev
add ut
4ba826d 
Signed-off-by: sevev <[email protected]>
@sevev
update
eb928f9 
Signed-off-by: sevev <[email protected]>
@sevev
update
63e7bee 
Signed-off-by: sevev <[email protected]>
@sevev
code format
acce8c2 
Signed-off-by: sevev <[email protected]>
@sevev
update
75643a0 
Signed-off-by: sevev <[email protected]>
@sevev
update
407b6e1 
Signed-off-by: sevev <[email protected]>
@sevev
update
6d268f6 
Signed-off-by: sevev <[email protected]>
@sevev
update
ba2c3ea 
Signed-off-by: sevev <[email protected]>
@sevev
fix lake pk compaction bug
ab73bd7 
Signed-off-by: sevev <[email protected]>
@sevev
update ut
7f7a679 
Signed-off-by: sevev <[email protected]>
@sevev
update
4ef7622 
Signed-off-by: sevev <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/AlterTableClauseAnalyzer.java 2 2 100.00% []
🔵 com/starrocks/alter/SchemaChangeHandler.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 129 / 132 (97.73%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/tablet_manager.cpp 23 26 88.46% [600, 609, 612]
🔵 be/src/storage/lake/meta_file.cpp 28 28 100.00% []
🔵 be/src/storage/lake/vertical_compaction_task.h 1 1 100.00% []
🔵 be/src/storage/lake/compaction_task.cpp 2 2 100.00% []
🔵 be/src/storage/lake/horizontal_compaction_task.cpp 8 8 100.00% []
🔵 be/src/storage/lake/vertical_compaction_task.cpp 4 4 100.00% []
🔵 be/src/storage/lake/tablet_reader.cpp 6 6 100.00% []
🔵 be/src/storage/lake/versioned_tablet.cpp 2 2 100.00% []
🔵 be/src/storage/lake/update_manager.cpp 8 8 100.00% []
🔵 be/src/storage/lake/txn_log_applier.cpp 35 35 100.00% []
🔵 be/src/storage/lake/horizontal_compaction_task.h 1 1 100.00% []
🔵 be/src/storage/lake/schema_change.cpp 2 2 100.00% []
🔵 be/src/storage/lake/rowset.cpp 9 9 100.00% []

@sevev sevev merged commit 3c8d168 into StarRocks:main Jul 30, 2024
53 of 60 checks passed
@wanpengfei-git wanpengfei-git mentioned this pull request Jul 30, 2024
Closed
11 tasks
@sevev
Copy link
Contributor Author

sevev commented Jul 31, 2024

@mergify backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@sevev @mergify
[Feature] Support add/drop filed for struct column in share-data mode (…
8ad4ff4 
…#48430)

Support add/drop field for struct column in shared-data mode.

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 3c8d168)

# Conflicts:
#	be/src/common/config.h
@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 31, 2024
@mergify @sevev
[Feature] Support add/drop filed for struct column in share-data mode…
83a484d 
… (backport #48430) (#49192)

Signed-off-by: sevev <[email protected]>
Co-authored-by: zhangqiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@packy92 packy92 packy92 approved these changes

@starrocks-xupeng starrocks-xupeng Awaiting requested review from starrocks-xupeng

Assignees

@HangyuanLiu HangyuanLiu

@sevev sevev

Labels
3.3-merged behavior_changed PROTO-REVIEW version:3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Add/drop Field for struct column
7 participants
@sevev @wyb @dirtysalt @HangyuanLiu @starrocks-xupeng @packy92 @wanpengfei-git