Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded modules to cleanup code base #17

Open
exoticDFT opened this issue Feb 5, 2021 · 0 comments · May be fixed by #18
Open

Remove unneeded modules to cleanup code base #17

exoticDFT opened this issue Feb 5, 2021 · 0 comments · May be fixed by #18
Assignees
@cookiew
Labels
Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. Good First Issue Good for newcomers Help wanted! Extra attention is needed for this issue Priority: 3 - Normal Moderate priority that may influence functionality or other issues Type: Enhancement Approved issues that will help enhance our AV stack

Comments

@exoticDFT
Copy link
Member

We have a few planner modules, map updaters, etc. in the code that are not currently used in our current pipeline and might not be needed going forward. Any unnecessary modules should be removed to reduce confusion.
@exoticDFT exoticDFT added Priority: 3 - Normal Moderate priority that may influence functionality or other issues Type: Enhancement Approved issues that will help enhance our AV stack Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. Help wanted! Extra attention is needed for this issue Good First Issue Good for newcomers labels Feb 5, 2021
exoticDFT added a commit that referenced this issue Feb 6, 2021
@exoticDFT
Issue #17: Removes some old nodes
c95eced 
- Removes several older nodes and modules that are no longer used for our AV stack.
- Moves the run_challenge_test module to the utilities directory as this is more appropriate location for the module.
exoticDFT added a commit that referenced this issue Feb 8, 2021
@exoticDFT
Issue #17: Removes old launch files
c8e9948 
- Removes several of the older launch files that would no longer work.
exoticDFT added a commit that referenced this issue Feb 8, 2021
@exoticDFT
Issue #17: Updates the name of a file
198dc1d 
- Renames the constants file to include the _module notation, to better represent the file type.
@exoticDFT exoticDFT linked a pull request Feb 8, 2021 that will close this issue
Open
exoticDFT added a commit that referenced this issue Feb 9, 2021
@exoticDFT
Issue #17: Cleans up the repository
c53e871 
- Removes several unneeded files from the repository.
- Renames controller node file to match the name of the class within.
  - Updates launch file to use this new name.
- Renames possible_paths file to match pep8 standard.
  - Updates files to use this new module name.
- Moves visualization/testing script from root directory to utilities directory.
exoticDFT added a commit that referenced this issue Feb 9, 2021
@exoticDFT
Issue #17: Updates filename
37548c6 
- Updates the file name of the MCity Challenge Runner program to match the program's name.
@cookiew cookiew self-assigned this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cookiew cookiew

Labels
Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. Good First Issue Good for newcomers Help wanted! Extra attention is needed for this issue Priority: 3 - Normal Moderate priority that may influence functionality or other issues Type: Enhancement Approved issues that will help enhance our AV stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merges in recent changes from "Node cleanup" branch StanfordMSL/carla_circle
2 participants
@cookiew @exoticDFT