Replace old method of registration with global registration in robottelo #14034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shweta83
force-pushed
the
remove_katello_ca_robottelo
branch
3 times, most recently
from
adf8cd6
to
277ccca
Compare
shweta83
added
CherryPick
shweta83
force-pushed
the
remove_katello_ca_robottelo
branch
from
277ccca
to
9c1ce40
Compare
|
This pull request has not been updated in the past 45 days. |
|
This pull request is now being closed after stale warnings. |
shweta83
force-pushed
the
remove_katello_ca_robottelo
branch
7 times, most recently
from
5452229
to
37ea130
Compare
ogajduse
approved these changes
May 13, 2024
Griffin-Sullivan
approved these changes
May 13, 2024
robottelo/hosts.py
Outdated
Comment on lines
801
to
802
| def api_register(self, target, **kwargs): | ||
| """Register a content host using the API. |
There was a problem hiding this comment.
I feel like we could either name this something related to global registration like def globally_register or leave the name as is and update the description to mention global registration like Register a content host using Global Registration.
There was a problem hiding this comment.
globally register sounds odd but I can update the description of this.
There was a problem hiding this comment.
Yeah it's not a great name that's why I thought at least the description 😄
There was a problem hiding this comment.
+1 to keep the name and extend docstring
There was a problem hiding this comment.
+1 to this. Tying this in explicitly to global registration should make it more clear why this is the method being used going forward.
sambible
approved these changes
May 13, 2024
shweta83
force-pushed
the
remove_katello_ca_robottelo
branch
from
4aa4b71
to
f14444c
Compare
This was referenced May 13, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 4, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 5, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 5, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 5, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 5, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 5, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 6, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 6, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 11, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 11, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 11, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 11, 2024
shweta83
added a commit
to shweta83/robottelo
that referenced
this pull request
Jun 11, 2024
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Robottelo is still using old method of registration using katello-ca certs which is deprecated.
Solution
With this PR, all the instances of old method of registration will be replaced with global registration.
Related Issues