-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] [ActivationKeys] Update tests to be SCA-compliant #14753
[RFE] [ActivationKeys] Update tests to be SCA-compliant #14753
Conversation
9d4b947
to
2a777d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a few comments. PRT pending.
trigger: test-robottelo |
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
- IMHO, make
activation-key
tests SCA-compliant and in another PR, take remaning things like, use of global registration template method. - I will leave up to author rather to include all changes in same PR or make separate PR for that.
@@ -611,11 +605,11 @@ def test_positive_fetch_product_content(target_sat, function_entitlement_manifes | |||
organization=org, repository=[rh_repo_id, custom_repo.id] | |||
).create() | |||
cv.publish() | |||
ak = target_sat.api.ActivationKey(content_view=cv, organization=org).create() | |||
cvv = cv.read().version[0].read() | |||
cvv.promote(data={'environment_ids': lce.id, 'force': True}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of 'force': True
is require during promotion?
@ColeHiggins2 can you rebase? I think the GR is solved by #14034 merged 3 days ago. |
2a777d3
to
dc0cfc5
Compare
trigger: test-robottelo |
PRT Result
|
dc0cfc5
to
8320360
Compare
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some unresolved comments above and the CI/CQ fails with
* Enumerated list ends without a blank line; unexpected unindent.
:steps:
1. Create a custom repo
> 2. Create ak and add custom repo to ak
4. Register a rhel6 chost with the ak
Can you address the comments and fix the CI/CQ?
8320360
to
65d017e
Compare
trigger: test-robottelo |
PRT Result
|
PRT Result
|
trigger: test-robottelo |
f9be5ac
to
37aff54
Compare
trigger: test-robottelo |
PRT Result
|
PRT Result
|
trigger: test-robottelo |
PRT Result
|
37aff54
to
79ce19d
Compare
Seems like a duplicate uuid made its way in to master causing code quality failures. I updated the test in repository.py to fix it. |
79ce19d
to
1751f4e
Compare
…14753) * Updating AK to SCA Only * Updating AK api test for sca only * Fixing UI tests * update to function instead of module * Addressing comments and updating errors * Updating function target sat to target sat * Updating typo enumerated list * Adding markers for prt * fixing pr runner failures
SCA is now the default in 6.16. This PR is for updating all tests under the Activation Key Component
SAT-24352