Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target in test_host_registration_end_to_end #15306

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix target in test_host_registration_end_to_end #15306

merged 1 commit into from
Jun 10, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Jun 4, 2024 •
edited
Loading

Problem Statement

target nc is nailgun object of Decclass which fails below error to run API endpoint as its not Satellite object, which is broken after #14034

AttributeError: 'DecClass' object has no attribute 'satellite'

Solution

Here we need target Satellite object and smart_proxy kwarg smart_proxy=nc to fix this issue

@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z labels Jun 4, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jun 4, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner June 4, 2024 14:01
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_host_registration_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7276
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========= 3 failed, 13 deselected, 256 warnings in 2920.13s (0:48:40) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 4, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7277
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========= 3 failed, 13 deselected, 264 warnings in 2864.73s (0:47:44) ==========

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_host_registration_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7288
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========= 3 failed, 13 deselected, 227 warnings in 2460.22s (0:41:00) ==========

amolpati30

This comment was marked as resolved.

Sign in to view

@jyejare jyejare removed the 6.16.z label Jun 5, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_host_registration_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7326
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========= 3 passed, 13 deselected, 249 warnings in 2714.36s (0:45:14) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 7, 2024
This was referenced Jun 8, 2024
Merged
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 removed CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 labels Jun 8, 2024
@Gauravtalreja1 Gauravtalreja1 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master and removed 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 8, 2024
shubhamsg199
shubhamsg199 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shubhamsg199 shubhamsg199 merged commit f023a06 into SatelliteQE:master Jun 10, 2024
18 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the fix-capsule-registration-api branch June 10, 2024 09:47
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Fix target in test_host_registration_end_to_end (SatelliteQE#15306)
165899b 
Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolpati30 amolpati30 amolpati30 approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gauravtalreja1 @Satellite-QE @shweta83 @shubhamsg199 @amolpati30 @jyejare