Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new support for feature manifest expires soon #1385

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented May 8, 2024

Problem Statement

REF - Notification when manifest is expiring soon
https://bugzilla.redhat.com/show_bug.cgi?id=2075163#c23

Solution

Add functionality in entities and view to read mafifest expiring soon message.

Related Issues

Robottelo PR-SatelliteQE/robottelo#15003

Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, pending prt pass of robottelo MR

@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 047c553 to cdb9813 Compare May 10, 2024 07:01
@vijaysawant vijaysawant requested a review from shweta83 May 10, 2024 07:06
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending question

airgun/entities/subscription.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion plus I would lean towards @jyejare 's proposal for an exception.

airgun/entities/subscription.py Outdated Show resolved Hide resolved
@vijaysawant vijaysawant marked this pull request as draft May 13, 2024 07:15
@vijaysawant vijaysawant marked this pull request as ready for review May 15, 2024 12:39
@vijaysawant vijaysawant requested review from a team and jyejare May 15, 2024 12:39
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@omkarkhatavkar
Copy link
Collaborator

@vijaysawant can you check the ci warnings?

@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from cbcaa80 to 2ba4e74 Compare May 21, 2024 11:55
@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 2ba4e74 to 763de08 Compare May 22, 2024 10:24
@omkarkhatavkar omkarkhatavkar merged commit cf03f59 into SatelliteQE:master May 22, 2024
7 checks passed
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jun 22, 2024
* added new support for feature  manifest expires soon

* add & update function from subscription entities

* new approach to read manifest expire message and date

* update xpath for manage manifest alert message

* update xpaths for subscription manager manifest modal box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants