Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest expiration date appearance of header and message #1443

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Manifest expiration date appearance of header and message #1443

merged 2 commits into from
Jun 26, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem

  • Considering newly implemented 6.16.0 feature/RFE "Notification when manifest is going to expire" and reported bug "Manifest expiration date (year) shows older for all manifest" it is neccessary to check manifest expiration message is disappearing when manifest upload very first time into organization.
  • It was left behind because related added new support for feature manifest expires soon #1385 merged very early phase of testing.
  • During phoenix qe team discussion, we have decided to open new robottelo PR and airgun PR to validate manifest expiration header message functionality before updating settings value (expire_soon_days)

Solution

Implemented function will return True or False base on availability of header message on manage manifest modal box.

Related PR

Robottelo SatelliteQE/robottelo#15500

@vijaysawant vijaysawant added No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Jun 25, 2024
@vijaysawant vijaysawant mentioned this pull request Jun 25, 2024
Merged
@vijaysawant vijaysawant force-pushed the manifest-expiration-date-appearance-of-header-and-message branch from 1297d68 to a04b17b Compare June 25, 2024 11:35
@vijaysawant vijaysawant force-pushed the manifest-expiration-date-appearance-of-header-and-message branch from a04b17b to f9ad824 Compare June 25, 2024 11:41
@vijaysawant vijaysawant marked this pull request as ready for review June 25, 2024 11:42
ColeHiggins2
ColeHiggins2 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, pending comments

@vijaysawant vijaysawant force-pushed the manifest-expiration-date-appearance-of-header-and-message branch from 92b9b8f to 2a9204d Compare June 25, 2024 14:47
@sambible sambible merged commit db0ea25 into SatelliteQE:master Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@sambible sambible sambible approved these changes

@LadislavVasina1 LadislavVasina1 Awaiting requested review from LadislavVasina1

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

Assignees

@vijaysawant vijaysawant

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijaysawant @sambible @ColeHiggins2 @LadislavVasina1 @damoore044