Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.16.0 feature manifest expiring soon #15003

Merged
merged 9 commits into from
Jun 21, 2024
Merged

6.16.0 feature manifest expiring soon #15003

merged 9 commits into from
Jun 21, 2024

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented May 8, 2024 •
edited
Loading

Problem Statement

REF - Notification when manifest is expiring soon
https://bugzilla.redhat.com/show_bug.cgi?id=2075163#c23
If no message alert "Manifest expiring soon" present then we can update 'expire_soon_days` value from settings page.

Note: Update 'settings values' part of test module is not working due to unsopported functionality
session.settings.update(f'name = {property_name}', property_value)
I just keep it for future use once the functionality gets added.

Solution

Add automation coverage for both parts

Related Issues

Airgun PR-SatelliteQE/airgun#1385

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385

@vijaysawant vijaysawant added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 8, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner May 8, 2024 18:47
@vijaysawant vijaysawant mentioned this pull request May 8, 2024
Merged
damoore044
damoore044 requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just a couple questions and tiny docstring fix

tests/foreman/ui/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_subscription.py Show resolved Hide resolved
tests/foreman/ui/test_subscription.py Show resolved Hide resolved
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6852
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 failed, 10 deselected, 21 warnings in 875.94s (0:14:35) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 9, 2024
@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 1a999b2 to fefaeb4 Compare May 9, 2024 12:34
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6854
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 21 warnings in 905.82s (0:15:05) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 9, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024
@vijaysawant vijaysawant requested a review from shweta83 May 10, 2024 07:05
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6874
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 21 warnings in 987.09s (0:16:27) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 10, 2024
vsedmik
vsedmik reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for discussion.

tests/foreman/ui/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_subscription.py Outdated Show resolved Hide resolved
@vijaysawant vijaysawant marked this pull request as draft May 13, 2024 07:15
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6910
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 failed, 10 deselected, 21 warnings in 943.57s (0:15:43) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 13, 2024
@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 8546a1d to e13322d Compare May 13, 2024 18:33
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6911
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 21 warnings in 996.63s (0:16:36) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR PRT-Passed Indicates that latest PRT run is passed for the PR labels May 13, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6925
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 1171.28s (0:19:31) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 14, 2024
@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 652f046 to 02d68ac Compare June 5, 2024 14:02
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7303
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 failed, 10 deselected, 20 warnings in 760.29s (0:12:40) ===========

jyejare
jyejare requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending passing PRT.

Looks good but just a suggestion about constant.

robottelo/constants/__init__.py Show resolved Hide resolved
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385
Katello:
    katello: 11019

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7323
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 failed, 10 deselected, 20 warnings in 1941.40s (0:32:21) ==========

@vijaysawant vijaysawant force-pushed the 6.16-feature-Notification-when-manifest-is-going-to-expire branch from 02d68ac to 78a06c3 Compare June 7, 2024 16:03
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385
Katello:
    katello: 11019

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7327
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 1928.69s (0:32:08) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 7, 2024
@vijaysawant
Copy link
Contributor Author

Moving this PR to draft because of in-progress work from developer on BZ which is related to this PR (impacting flow of execution)

@vijaysawant vijaysawant marked this pull request as draft June 13, 2024 11:57
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7433
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 965.15s (0:16:05) ===========

@vijaysawant vijaysawant marked this pull request as ready for review June 18, 2024 17:01
vsedmik
vsedmik approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of proposals added.

tests/foreman/ui/test_subscription.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_subscription.py Show resolved Hide resolved
tests/foreman/ui/test_subscription.py Outdated Show resolved Hide resolved
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 21, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_check_manifest_validity_notification'
airgun: 1385

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7468
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_check_manifest_validity_notification --external-logging
Test Result : ========== 1 passed, 10 deselected, 20 warnings in 1003.86s (0:16:43) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 21, 2024
@vijaysawant vijaysawant requested a review from vsedmik June 21, 2024 12:04
vsedmik
vsedmik approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sambible sambible merged commit d6a2d9e into SatelliteQE:master Jun 21, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vijaysawant @damoore044 @jyejare
6.16.0 feature manifest expiring soon (SatelliteQE#15003)
b7e0ca1 
* 6.16.0 feature manifest expiring soon

* Update test_subscription.py

Co-authored-by: David Moore <[email protected]>

* use cli way to update settings of expire soon days

* use correct Web UI way to update settings of 'expire soon days'

* new approach to read manifest expire message and date

* use of sca enabled manifest to get expires manifest soon message

* upload new expire manifest & update test case

* add manifest expired time in robottelo constants and tested

* incorporate minor review comments

---------

Co-authored-by: David Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible sambible approved these changes

@jyejare jyejare jyejare approved these changes

@shweta83 shweta83 Awaiting requested review from shweta83

Assignees

@vijaysawant vijaysawant

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vijaysawant @Satellite-QE @jyejare @sambible @shweta83 @vsedmik @damoore044