-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Restructuring the test suite #480
Comments
Good idea! I liked the idea of separating unit and integration tests. Here some other suggestions (not mandatory): Also, the acceptance tests are quite important, we should improve them by bringing more examples of real flights to be tested. |
Nice! Gonna check the suggestions! |
------"Algorithm" that will run the reorganization:------ 1. For each module x in the tests directory, copy x into the new directory unit tests. Pull request in each step. |
Is your feature request related to a problem? Please describe.
RocketPy test suite is currently very slow. Among other factors, this has to do with the fact that unit tests and integration tests (which are being treated as unit tests in many ways) are being kept in the same folder.
Describe the solution you'd like
Restructuring the test suite will bring clarity as well as proper treatment depending on the nature of the test. With regards to the unit tests, they need to be refactored: commented, rewritten and etc.
Additional context
Even though some methods had tests written for them, bugs occurred. Of course, this situation might happen even though unit tests are available for a certain method. However, that also indicates that the test suite/testing process is not robust enough. As an example of this, check this bug:
#476
The text was updated successfully, but these errors were encountered: