TST: Environment unit tests refactoring

[GabrielBarberini]

Pull request type

• Code maintenance (refactoring, formatting, tests)

Checklist

• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally --> All tests that were previously passing continued to pass

Breaking change

• No

Additional information

• Small refactoring with emphasis on test clarity and DRY;
• FUP on RFC - RocketPy pytest architecture

[Gui-FernandesBR]

Good PR.

Tests not passing? That catches my attention. Investigating it right now.

[GabrielBarberini]

Good PR.

Tests not passing? That catches my attention. Investigating it right now.

I summon: works on my machine 😂

tests/unit/test_environment.py .................. [100%]

Let me know if you find any issues

[Gui-FernandesBR]

Good PR.
Tests not passing? That catches my attention. Investigating it right now.

I summon: works on my machine 😂

tests/unit/test_environment.py .................. [100%]

Let me know if you find any issues

Fair enough lol,

Are you using MacOS? Which python version?

[GabrielBarberini]

Good PR.
Tests not passing? That catches my attention. Investigating it right now.

I summon: works on my machine 😂
tests/unit/test_environment.py .................. [100%]
Let me know if you find any issues

Fair enough lol,

Are you using MacOS? Which python version?

MacOS Sonoma 14.2 Beta (23C5041e) under Python 3.11.5

[Gui-FernandesBR]

@GabrielBarberini a problem is that you renamed the variable example_env_robust but a lot of tests used it.
Try to run all the tests at once, it doesn't take that long to be executed. (I usually run make pytest, see the Makefile in the root directory).

Try replacing example_env_robust to example_spaceport_env.

More replacements will be necessary I think.

[GabrielBarberini]

@GabrielBarberini a problem is that you renamed the variable example_env_robust but a lot of tests used it. Try to run all the tests at once, it doesn't take that long to be executed. (I usually run make pytest, see the Makefile in the root directory).

Try replacing example_env_robust to example_spaceport_env.

More replacements will be necessary I think.

Hmmm! You are right. Didn't notice this dependency.

Fixed :)

Meanwhile I'll run all the others just in case

[GabrielBarberini]

All good now @Gui-FernandesBR

Sorry for that, for some reason I assumed the env fixtures were used only by the env tests.

Lastly, I tried to use a fixture teardown for env fixtures, but since other modules use env fixtures differently, it ended up conflicting with my change. So I had to set a request.addfinalizer() inside the unit env test that requires teardown (for deleting the environment.json file).

For review convenience, I added it as a separate commit.

Edit: I'll have to find another way to tear this down as the way I attempted is not passing internal pytest validations, maybe I'll just rollback to the way it was, one sec.

[GabrielBarberini]

Now all good.

[codecov]

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.62%. Comparing base (fda6b33) to head (f4f658c).
Report is 18 commits behind head on develop.

Files	Patch %	Lines
rocketpy/environment/environment.py	55.55%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #571      +/-   ##
===========================================
- Coverage    72.62%   72.62%   -0.01%     
===========================================
  Files           59       59              
  Lines         9598     9607       +9     
===========================================
+ Hits          6971     6977       +6     
- Misses        2627     2630       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

Easy to review a PR when it is well constructed and fixes one problem at time.

My comments are only related to small convention details.
Code works, PR is clear, that's what really matters.

[GabrielBarberini]

Easy to review a PR when it is well constructed and fixes one problem at time.

My comments are only related to small convention details. Code works, PR is clear, that's what really matters.

Thanks for the feedback! I'll address your requests soon

[Gui-FernandesBR]

This PR contributes to #480

[Gui-FernandesBR]

Thanks again for the contribution, @GabrielBarberini ,
I commented on the conversations, you can mark them as resolved once you feel they are done.

I believe we are close to approve/merge

[Gui-FernandesBR]

LGTM