Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Reorganizing testing modules into unit and integration tests #628

Merged
merged 18 commits into from
Jul 4, 2024

Conversation

lucasfourier
Copy link
Contributor

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The tests were not fully organized.

New behavior

Now the tests are into place, divided into unit and integration tests accordingly.

Breaking change

  • Yes
  • No

Additional information

image

Fast unit tests around here!

@lucasfourier lucasfourier added the Tests Regarding Tests label Jul 3, 2024
@lucasfourier lucasfourier requested a review from a team as a code owner July 3, 2024 14:26
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (bd3f098) to head (a21bf90).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #628      +/-   ##
===========================================
- Coverage    66.29%   61.01%   -5.28%     
===========================================
  Files           70       70              
  Lines        10334    10320      -14     
===========================================
- Hits          6851     6297     -554     
- Misses        3483     4023     +540     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasfourier lucasfourier changed the title TST: Reorganizing test_function.py into unit and integration tests TST: Reorganizing testing modules into unit and integration tests Jul 3, 2024
@lucasfourier
Copy link
Contributor Author

Tests were put into place, waiting for review. Work was mostly moving tests and classifying them. Since there were many tests, naturally there may be tests in the wrong place.

@Gui-FernandesBR Gui-FernandesBR merged commit d4166ac into develop Jul 4, 2024
8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the tst/unit-integration-tests branch July 4, 2024 00:10
@Gui-FernandesBR Gui-FernandesBR linked an issue Jul 4, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Regarding Tests
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

TST: Restructuring the test suite
2 participants