-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Splitting unit testing module from non unit testes inside the new 'unit' folder for the several testing modules. #499
Conversation
New folders were created (called 'unit' and 'integration') and a test module named 'test_function.py' was put inside the folder called 'unit.'
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #499 +/- ##
===========================================
+ Coverage 71.04% 71.17% +0.13%
===========================================
Files 55 55
Lines 9266 9277 +11
===========================================
+ Hits 6583 6603 +20
+ Misses 2683 2674 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Removing output.json, pytest_html_report.html and the other unnecessary file of the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I finally understand this PR after the discussions we had yesterday.
I have nothing against the new tst/testing-suite-reestructuring
file.
However, what is the difference between this new file and the currently https://github.com/RocketPy-Team/RocketPy/blob/develop/tests/test_function.py file? I was under the impression you were creating new code but I think you simply copy and past code.
Seems like you duplicated a file. The tests in the tests/test_function.py still exist so you're testing the same thing twice. If that's true, you should use git mv command to move one file to another folder. In that case I suggest you to delete the branch and start this work again.
Actually, what was classified as an unit test was kept inside the test_function.py module inside the folder 'unit'. What was not an unit test remained intact in the original test_function.py file. Thanks a lot to @Gui-FernandesBR which greatly contributed this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, Great work @lucasfourier !!
In the future we want to run unit tests before integration tests when triggering the github actions, this will save us some time.
Next step is defining the integration tests schema, I"m still not sure how to do or where to save them.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Every testing module is inside the 'tests' folder.
New behavior
Inside a newly created folder called 'unit', testing modules which contained only tests classified as unit tests were brought inside the unit folder. There are nine modules inside the 'unit' folder, and all of them should contain only unit tests. This is the beginning of the procedure described in #480. Every testing module outside this 'unit' folder contains only tests which are not unit tests. The test_tank.py was not further analyzed because it needs to be worked on more carefully later.
Breaking change
Additional information
This PR is part of the effort to reorganize the testing suite. Further information can be found here: #480
New behavior: