Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's Rocket.draw it so we can double check our parameters #222

Closed
Gui-FernandesBR opened this issue Sep 10, 2022 · 4 comments · Fixed by #419
Closed

Let's Rocket.draw it so we can double check our parameters #222

Gui-FernandesBR opened this issue Sep 10, 2022 · 4 comments · Fixed by #419
Labels
Enhancement New feature or request, including adjustments in current codes
Milestone
EuRoC 2023

Comments

@Gui-FernandesBR
Copy link
Member

Is your feature request related to a problem? Please describe.

Based on recent comment we got on our discord server, I believe that it would be really good if we have a function to draw the rocket geometry after we design the

Describe the solution you'd like

Simple: After inputting every parameter, I'd like to use Rocket.draw() to see what is the final geometry of the rocket that will be used on the simulation, specially when talking about the fins, this is quite important!

Additional context
image

image
@Gui-FernandesBR
Copy link
Member Author

It turns out that we've already see something like this working on a hackathon a while ago... It's possible to check it by here: https://github.com/RocketPy-Team/Hackathon_2020/pull/96

@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes and removed feature labels Sep 14, 2022
@Gui-FernandesBR
Copy link
Member Author

Already started on #263

@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.1.0 milestone Jan 11, 2023
@Gui-FernandesBR Gui-FernandesBR mentioned this issue Sep 6, 2023
Merged
15 tasks
@CabGT CabGT mentioned this issue Sep 13, 2023
Closed
15 tasks
@Gui-FernandesBR Gui-FernandesBR mentioned this issue Sep 23, 2023
Merged
10 tasks
@Gui-FernandesBR Gui-FernandesBR linked a pull request Sep 25, 2023 that will close this issue
ENH: rocket drawing #419
Merged
10 tasks
@Gui-FernandesBR
Copy link
Member Author

Rocket draws are ready, just waiting for the motors draws (#436 ) before closing this one.

@MateusStano MateusStano moved this from Long-Term to Next Version in LibDev Roadmap Nov 5, 2023
@Gui-FernandesBR
Copy link
Member Author

This is coming in the next release. Great one.

@github-project-automation github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
LibDev Roadmap
Status: Closed
Milestone
EuRoC 2023
Development

Successfully merging a pull request may close this issue.

ENH: rocket drawing RocketPy-Team/RocketPy
1 participant
@Gui-FernandesBR