-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: nosecone draw and bluffness #372
Conversation
…uffiness. Addition of draw function in nosecone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @CabGT , I see a good future for this PR, meaning that small adjusts would allow us to merge.
@MateusStano , please give us a little help in this one as it is needed to be merged before we start to move plots/prints from the AeroSurface.py file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here @CabGT , congratulations.
The implementation allows for sophisticated plotting the nosecone shape.
This is an important step in the roadmap of the rocket drawing function #222 .
I can confirm that the code is working in my machine.
I've tested it for different nose kinds and different bluffness ratio values.
I did some minor adjustments (basically some typos) in the last 3 PRs. Those were so tiny details that I preferred committing instead of requesting change.
A future PR containing some refactoring operations would be welcome. Here as some tasks:
- create unittests to check different values of bluffness
- clean the
kind.setter
method, moving some of its new operations to the "evaluate_geometry_parameters" method - move the
draw()
method to the aero_surface_plots.py file, to accomplish - I think it's time for us creating a
coods
parameter for the AeroSurface class. Again, this would help us to generate the Let's Rocket.draw it so we can double check our parameters #222 solution. - When the bluffness==0, it sometimes throw an warning. But I didn't see the impact of that in the rest of the code
Please check my commits and merge it when you feel confortable.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyCode base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the new behavior?
This update introduces the function to create different nosecone type curves.
It considers the bluffiness chosen by the users.
Also adds a drawing function for the nosecone, which allows visualization of it.
Does this introduce a breaking change?