Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: nosecone draw and bluffness #372

Merged
merged 14 commits into from
Sep 6, 2023
Merged

Conversation

CabGT
Copy link
Contributor

@CabGT CabGT commented Jun 1, 2023

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the new behavior?

This update introduces the function to create different nosecone type curves.
It considers the bluffiness chosen by the users.
Also adds a drawing function for the nosecone, which allows visualization of it.

Does this introduce a breaking change?

  • Yes
  • No

…uffiness.

Addition of draw function in nosecone.
@CabGT CabGT requested a review from giovaniceotto as a code owner June 1, 2023 23:15
@CabGT CabGT self-assigned this Jun 1, 2023
@CabGT CabGT added the Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic label Jun 1, 2023
@CabGT CabGT modified the milestones: Release v1.0.0, Release v1.1.0 Jun 1, 2023
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @CabGT , I see a good future for this PR, meaning that small adjusts would allow us to merge.

@MateusStano , please give us a little help in this one as it is needed to be merged before we start to move plots/prints from the AeroSurface.py file

tests/test_rocket.py Show resolved Hide resolved
rocketpy/AeroSurface.py Show resolved Hide resolved
rocketpy/AeroSurface.py Show resolved Hide resolved
rocketpy/AeroSurface.py Outdated Show resolved Hide resolved
rocketpy/AeroSurface.py Outdated Show resolved Hide resolved
rocketpy/AeroSurface.py Outdated Show resolved Hide resolved
rocketpy/AeroSurface.py Show resolved Hide resolved
rocketpy/AeroSurface.py Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR marked this pull request as draft September 5, 2023 12:29
@Gui-FernandesBR Gui-FernandesBR marked this pull request as ready for review September 6, 2023 02:42
@Gui-FernandesBR Gui-FernandesBR self-requested a review September 6, 2023 02:42
@Gui-FernandesBR Gui-FernandesBR changed the title ENH: nosecone draw and bluffiness ENH: nosecone draw and bluffness Sep 6, 2023
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here @CabGT , congratulations.

The implementation allows for sophisticated plotting the nosecone shape.
This is an important step in the roadmap of the rocket drawing function #222 .

I can confirm that the code is working in my machine.
I've tested it for different nose kinds and different bluffness ratio values.
I did some minor adjustments (basically some typos) in the last 3 PRs. Those were so tiny details that I preferred committing instead of requesting change.

A future PR containing some refactoring operations would be welcome. Here as some tasks:

  • create unittests to check different values of bluffness
  • clean the kind.setter method, moving some of its new operations to the "evaluate_geometry_parameters" method
  • move the draw() method to the aero_surface_plots.py file, to accomplish
  • I think it's time for us creating a coods parameter for the AeroSurface class. Again, this would help us to generate the Let's Rocket.draw it so we can double check our parameters #222 solution.
  • When the bluffness==0, it sometimes throw an warning. But I didn't see the impact of that in the rest of the code

Please check my commits and merge it when you feel confortable.

@MateusStano MateusStano merged commit b700000 into beta/v1.0.0 Sep 6, 2023
@MateusStano MateusStano deleted the enh/-nosecone-draw branch September 6, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants