-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: rocket drawing #419
ENH: rocket drawing #419
Conversation
Have you ever wondered if there is something better than "spectacular"? Great Work!! I've been able to debug some rockets thanks to the new implementations. The only flaw I could find so far is the position of the legend, this is a problem with matplotlib in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would approve if I wasn't the PR's author
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCurrent behavior
We know that sometimes it is hard to check if we have correctly defined the rocket before simulating it.
Also, sometimes we just need to ensure that our rocket looks good on RocketPy.
New behavior
Just added a method to draw the entire rocket. You can already try the
Rocket.draw()
method.Here the first example:
Breaking change
Additional information
Some comments on the reviewing process: