-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/ fix previous nosecone drawing #410
Closed
CabGT
wants to merge
996
commits into
RocketPy-Team:master
from
CabGT:bug/-fix-previous-nosecone-drawing
Closed
Bug/ fix previous nosecone drawing #410
CabGT
wants to merge
996
commits into
RocketPy-Team:master
from
CabGT:bug/-fix-previous-nosecone-drawing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessary changes to all other files
…tors-optimization Enh/liquid motors optimization
Co-authored-by: Guilherme <[email protected]>
Co-authored-by: MateusStano <[email protected]>
Co-authored-by: MateusStano <[email protected]>
Co-authored-by: MateusStano <[email protected]>
…ons-class ENH: RailButtons Class
Co-authored-by: phmbressan <[email protected]>
…ective-rail BUG: Wrong Effective Rail
…um-acceleration-during-burn-print ENH: Add Maximum Acceleration During Burn Print
Co-authored-by: MateusStano <[email protected]>
…sis-tests-slow-plt TST: env analysis tests on slow option opens matplotlib (solve RocketPy-Team#380)
…sis-ASL-mistake BUG: env analysis altitudes ASL mistake (solve RocketPy-Team#371)
…-draw ENH: nosecone draw and bluffness
…l-fins-roll-damping-factor-calculation BUG: EllipticalFins Roll Damping Factor Calculation
Add testing cases for new motor classes: LiquidMotor and HybridMotor
…utputs ENH: airfoil outputs (resolve RocketPy-Team#144)
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyCode base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the current behavior?
Check up a warning that shows up on the nosecone draw method.
Change the drawing method to a different folder for organization.
Follow up sugg
What is the new behavior?
Enter text here...
Does this introduce a breaking change?
Other information
create unittests to check different values of bluffness
clean the kind.setter method, moving some of its new operations to the "evaluate_geometry_parameters" method
move the draw() method to the aero_surface_plots.py file, to accomplish
I think it's time for us creating a coods parameter for the AeroSurface class. Again, this would help us to generate the #222 solution.
When the bluffness==0, it sometimes throw an warning. But I didn't see the impact of that in the rest of the code