Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ fix previous nosecone drawing #410

Closed

Conversation

CabGT
Copy link
Contributor

@CabGT CabGT commented Sep 13, 2023

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Check up a warning that shows up on the nosecone draw method.
Change the drawing method to a different folder for organization.
Follow up sugg

What is the new behavior?

Enter text here...

Does this introduce a breaking change?

  • Yes
  • No

Other information

create unittests to check different values of bluffness
clean the kind.setter method, moving some of its new operations to the "evaluate_geometry_parameters" method
move the draw() method to the aero_surface_plots.py file, to accomplish
I think it's time for us creating a coods parameter for the AeroSurface class. Again, this would help us to generate the #222 solution.
When the bluffness==0, it sometimes throw an warning. But I didn't see the impact of that in the rest of the code

phmbressan and others added 30 commits June 8, 2023 08:00
necessary changes to all other files
…tors-optimization

Enh/liquid motors optimization
MateusStano and others added 26 commits August 23, 2023 15:53
…um-acceleration-during-burn-print

ENH: Add Maximum Acceleration During Burn Print
…sis-tests-slow-plt

TST: env analysis tests on slow option opens matplotlib (solve RocketPy-Team#380)
…sis-ASL-mistake

BUG: env analysis altitudes ASL mistake (solve RocketPy-Team#371)
…l-fins-roll-damping-factor-calculation

BUG: EllipticalFins Roll Damping Factor Calculation
Add testing cases for new motor classes: LiquidMotor and HybridMotor
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants