Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchy to handle multiple matching rules for a failure #193

Merged
merged 4 commits into from
May 21, 2024

Conversation

oharan2
Copy link
Collaborator

@oharan2 oharan2 commented May 20, 2024

Currently, if we have more then one matching rule for a failure, the code will take the first rule matched and consider the second a "duplicate" ticket.

The goal is to prioritize it with first check if there's a rule with the same name, otherwise use patterns or duplication.

Workflow example:

  1. We have two rules defined, one for exact- and one for exact-step. But, the rule for exact-* is first in the list of rules and exact-step is second.
  2. A failure in exact-step is identified and paired with both rules.
  3. In this for loop, the first pair (exact-* rule) generates a bug.
  4. In the second iteration of the for loop, the failure pair with the exact-step rule does not generate a ticket, since it'll be identified as a duplicated failure.

@redhat-qe-bot
Copy link
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • This repository does not support retest actions
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@oharan2
Copy link
Collaborator Author

oharan2 commented May 20, 2024

/verified

@oharan2
Copy link
Collaborator Author

oharan2 commented May 20, 2024

/verified

@oharan2
Copy link
Collaborator Author

oharan2 commented May 21, 2024

/verified

@oharan2 oharan2 changed the title Add a hierarchy to handle multiple matching rules for a failure Add hierarchy to handle multiple matching rules for a failure May 21, 2024
Copy link
Collaborator

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@calebevans calebevans merged commit 2cf80ec into RedHatQE:main May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants