-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Firewatch base config #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report bugs in Issues The following are automatically added:
Available user actions:
Supported /retest check runs
Supported labels
|
/wip |
redhat-qe-bot2
changed the title
WIP: Add support for Firewatch base config
WIP: WIP: Add support for Firewatch base config
May 16, 2024
myakove
changed the title
WIP: WIP: Add support for Firewatch base config
WIP: Add support for Firewatch base config
May 21, 2024
…pport_base_config
…ized_over_pattern' and 'test_configuration_gets_failure_rules_with_pattern_overriding_specific_step'
Pending the merge of #193 |
/wip cancel |
/verified |
rh-bot-1
changed the title
WIP: Add support for Firewatch base config
Add support for Firewatch base config
May 21, 2024
…port_base_config
oharan2
force-pushed
the
support_base_config
branch
from
May 21, 2024 14:38
8dac89f
to
da97ebd
Compare
/verified |
/verified |
calebevans
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For occurring steps and workflows in our project, we want to initialize a source that holds our Firewatch base config.
Once set up (optional), our Openshift-ci env
FIREWATCH_CONFIG
values will be added on top of that.This PR allows the user to override the base config by:
For example:
The team consistently uses the rule
{"step": "failure", "ignore": "True"...}
and holds it in their base config file; a specific scenario might need to override it and set the "ignore" to "False".in this case, the scenario will mention this step in their
FIREWATCH_CONFIG
env var.Unit-tests main additions: