Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Firewatch base config #192

Merged
merged 16 commits into from
May 22, 2024

Conversation

oharan2
Copy link
Collaborator

@oharan2 oharan2 commented May 15, 2024

For occurring steps and workflows in our project, we want to initialize a source that holds our Firewatch base config.

Once set up (optional), our Openshift-ci env FIREWATCH_CONFIG values will be added on top of that.

This PR allows the user to override the base config by:

  • replacing steps with general patterns with specific step names and vice versa
  • updating existing rules with new logic.

For example:
The team consistently uses the rule {"step": "failure", "ignore": "True"...} and holds it in their base config file; a specific scenario might need to override it and set the "ignore" to "False".
in this case, the scenario will mention this step in their FIREWATCH_CONFIG env var.

Unit-tests main additions:

  • steps containing patterns and steps that matches them are co-existing when configured on the same config data
  • config data collected from both base config and additional logic from env var is functioning well

@redhat-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • This repository does not support retest actions
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@oharan2
Copy link
Collaborator Author

oharan2 commented May 16, 2024

/wip

@redhat-qe-bot2 redhat-qe-bot2 changed the title WIP: Add support for Firewatch base config WIP: WIP: Add support for Firewatch base config May 16, 2024
@myakove myakove changed the title WIP: WIP: Add support for Firewatch base config WIP: Add support for Firewatch base config May 21, 2024
@oharan2
Copy link
Collaborator Author

oharan2 commented May 21, 2024

Pending the merge of #193

@oharan2
Copy link
Collaborator Author

oharan2 commented May 21, 2024

/wip cancel

@oharan2
Copy link
Collaborator Author

oharan2 commented May 21, 2024

/verified

@rh-bot-1 rh-bot-1 removed the wip label May 21, 2024
@rh-bot-1 rh-bot-1 changed the title WIP: Add support for Firewatch base config Add support for Firewatch base config May 21, 2024
@oharan2
Copy link
Collaborator Author

oharan2 commented May 21, 2024

/verified

@rh-bot-1 rh-bot-1 removed the verified label May 22, 2024
@oharan2
Copy link
Collaborator Author

oharan2 commented May 22, 2024

/verified

Copy link
Collaborator

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants