Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 control migration #320

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

ros2 control migration #320

wants to merge 28 commits into from

Conversation

leungw16
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimisation

[required] Description

Phase 1 of migration to ros2_control. Currently replaces the functionality of the velocity controller while hopefully providing better odometry using built in ros2_controllers.

  • Added 2 custom packages (ros2_control_bringup, qutms_hw_interfaces) along with various ros2_control related dependencies
  • Modified vehicle urdf package to add 2 sets of virtual center wheels to interface hardware with the bicycle_steering_controller.
  • Modified the vehicle supervisor package to publish wheel position data and to aggregate the 2 rear wheel positions as the virtual center wheel position.

[optional] Usability concerns or breaking changes?

Current packages should not be affected by this change

b1n-ch1kn and others added 28 commits September 15, 2024 22:04
@leungw16 leungw16 self-assigned this Sep 23, 2024
@b1n-ch1kn
Copy link
Member

General comment about the state of the stack, given this builds on https://github.com/QUT-Motorsport/QUTMS_Driverless/tree/feature/2024-clean-and-refactor branch, I'll make a PR shortly for that to be opened first, then this can rebase ontop of that. We'll also merge this into a staging branch (cc @AlexCB192) rather than master, for track validating first

@leungw16 leungw16 changed the base branch from master to dev/track-day September 24, 2024 13:26
Base automatically changed from dev/track-day to master October 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants