feat(persons): improve persons scene copy #27028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
commented
Dec 18, 2024
| @@ -20,8 +20,7 @@ interface LabelType { | |||
| const labels: Record<ActorType, LabelType> = { | |||
| person: { | |||
| label: 'persons', | |||
| description: | |||
There was a problem hiding this comment.
I think this is still in reference to the legacy implementation. The current query looks like this:
SELECT id, id, created_at, 1
FROM persons
WHERE or(
ilike(properties.email, '%QUERY%'),
ilike(properties.name, '%QUERY%'),
ilike(toString(id), '%QUERY%'),
in(id, (SELECT person_id FROM person_distinct_ids WHERE ilike(distinct_id, '%QUERY%')))
)
ORDER BY created_at DESC
LIMIT 101 OFFSET 0
thmsobrmlr
commented
Dec 18, 2024
| @@ -52,7 +52,7 @@ export const personsManagementSceneLogic = kea<personsManagementSceneLogicType>( | |||
| { | |||
| key: 'persons', | |||
| url: urls.persons(), | |||
| label: 'People & groups', | |||
There was a problem hiding this comment.
We just list persons in this tab, no group.
thmsobrmlr
commented
Dec 18, 2024
There was a problem hiding this comment.
This is the legacy implementation that doesn't seem to be used any more.
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
anirudhpillai
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The copy on the persons page was confusing, see individual comments on the code.
Changes
Improves it. I also removed a legacy component that I think isn't used any more.
How did you test this code?
👀