feat(persons): improve persons scene copy (#27028)

PostHog · Dec 20, 2024 · 53133f1 · 53133f1
1 parent 3bb4386
commit 53133f1
Show file tree

Hide file tree

Showing 11 changed files with 8 additions and 54 deletions.
diff --git a/cypress/e2e/persons.cy.ts b/cypress/e2e/persons.cy.ts
@@ -4,7 +4,7 @@ describe('Persons', () => {
     })
 
     it('All tabs work', () => {
-        cy.get('h1').should('contain', 'People')
+        cy.get('h1').should('contain', 'Persons')
         cy.get('[data-attr=persons-search]').type('marisol').type('{enter}').should('have.value', 'marisol')
         cy.wait(200)
         cy.get('[data-row-key]').its('length').should('be.gte', 0)

diff --git a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--dark.png
diff --git a/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png b/frontend/__snapshots__/scenes-app-persons-groups--cohorts--light.png
diff --git a/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--groups--dark.png
diff --git a/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png b/frontend/__snapshots__/scenes-app-persons-groups--groups--light.png
diff --git a/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png b/frontend/__snapshots__/scenes-app-persons-groups--persons--dark.png
diff --git a/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png b/frontend/__snapshots__/scenes-app-persons-groups--persons--light.png
diff --git a/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx b/frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx
@@ -20,8 +20,7 @@ interface LabelType {
 const labels: Record<ActorType, LabelType> = {
     person: {
         label: 'persons',
-        description:
-            'Search by email or Distinct ID. Email will match partially, for example: "@gmail.com". Distinct ID needs to match exactly.',
+        description: 'Search by name, email, Person ID or Distinct ID.',
     },
     group: {
         label: 'groups',

diff --git a/frontend/src/scenes/persons-management/PersonsManagementScene.tsx b/frontend/src/scenes/persons-management/PersonsManagementScene.tsx
@@ -21,9 +21,11 @@ export function PersonsManagementScene(): JSX.Element {
     return (
         <>
             <PageHeader
-                caption={`A catalog of your product's end users, lists of users who have something in common to use in analytics or feature flags${
-                    showGroupsOptions ? ' and groups' : ''
-                }.`}
+                caption={
+                    showGroupsOptions
+                        ? 'A catalog of identified persons, groups, and your created cohorts.'
+                        : 'A catalog of identified persons and your created cohorts.'
+                }
                 buttons={activeTab?.buttons}
             />
 

diff --git a/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx b/frontend/src/scenes/persons-management/personsManagementSceneLogic.tsx
@@ -52,7 +52,7 @@ export const personsManagementSceneLogic = kea<personsManagementSceneLogicType>(
                     {
                         key: 'persons',
                         url: urls.persons(),
-                        label: 'People & groups',
+                        label: 'Persons',
                         content: <Persons />,
                     },
                     {

diff --git a/frontend/src/scenes/persons/PersonsSearch.tsx b/frontend/src/scenes/persons/PersonsSearch.tsx