Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persons): improve persons scene copy #27028

Merged
merged 3 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/persons.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ describe('Persons', () => {
})

it('All tabs work', () => {
cy.get('h1').should('contain', 'People')
cy.get('h1').should('contain', 'Persons')
cy.get('[data-attr=persons-search]').type('marisol').type('{enter}').should('have.value', 'marisol')
cy.wait(200)
cy.get('[data-row-key]').its('length').should('be.gte', 0)
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions frontend/src/queries/nodes/PersonsNode/PersonsSearch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ interface LabelType {
const labels: Record<ActorType, LabelType> = {
person: {
label: 'persons',
description:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still in reference to the legacy implementation. The current query looks like this:

SELECT id, id, created_at, 1
FROM persons
WHERE or(
    ilike(properties.email, '%QUERY%'), 
    ilike(properties.name, '%QUERY%'), 
    ilike(toString(id), '%QUERY%'), 
    in(id, (SELECT person_id FROM person_distinct_ids WHERE ilike(distinct_id, '%QUERY%')))
)
ORDER BY created_at DESC
LIMIT 101 OFFSET 0

'Search by email or Distinct ID. Email will match partially, for example: "@gmail.com". Distinct ID needs to match exactly.',
description: 'Search by name, email, Person ID or Distinct ID.',
},
group: {
label: 'groups',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ export function PersonsManagementScene(): JSX.Element {
return (
<>
<PageHeader
caption={`A catalog of your product's end users, lists of users who have something in common to use in analytics or feature flags${
showGroupsOptions ? ' and groups' : ''
}.`}
caption={
showGroupsOptions
? 'A catalog of identified persons, groups, and your created cohorts.'
: 'A catalog of identified persons and your created cohorts.'
}
buttons={activeTab?.buttons}
/>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const personsManagementSceneLogic = kea<personsManagementSceneLogicType>(
{
key: 'persons',
url: urls.persons(),
label: 'People & groups',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just list persons in this tab, no group.

label: 'Persons',
content: <Persons />,
},
{
Expand Down
47 changes: 0 additions & 47 deletions frontend/src/scenes/persons/PersonsSearch.tsx

This file was deleted.

Loading