Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp preference in recorder #26718

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

pauldambra
Copy link
Member

we should always prefer the snapshot timestamps for the start of a recording, even if the session started earlier based on event data

see: https://posthoghelp.zendesk.com/agent/tickets/21565

@pauldambra pauldambra requested a review from a team December 6, 2024 11:23
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@pauldambra pauldambra enabled auto-merge (squash) December 6, 2024 11:39
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra disabled auto-merge December 6, 2024 14:03
@pauldambra pauldambra merged commit 44d7ece into master Dec 6, 2024
96 checks passed
@pauldambra pauldambra deleted the fix/timestamp-preference branch December 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants