Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only measure start from snapshot data #26735

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pauldambra
Copy link
Member

follow-up to #26718

we're getting the event timestamp before the snapshot timestamp and not updating.

We only ever want to use the snapshot data start date so let's only do that

@pauldambra pauldambra requested review from daibhin and a team December 6, 2024 16:25
@pauldambra pauldambra enabled auto-merge (squash) December 6, 2024 16:25
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra force-pushed the fix/only-start-with-snapshot-time branch from c0254eb to 2149e72 Compare December 6, 2024 20:18
@pauldambra pauldambra merged commit 5fb09e4 into master Dec 6, 2024
96 checks passed
@pauldambra pauldambra deleted the fix/only-start-with-snapshot-time branch December 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants