fix: add gap at start of recording #26743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated70 snapshot changes in total. 0 added, 70 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated114 snapshot changes in total. 0 added, 114 modified, 0 deleted:
Triggered by this commit. |
ioannisj
reviewed
Dec 9, 2024
| return snapshotStart | ||
| // whichever is earliest | ||
| if (eventStart && snapshotStart) { | ||
| return eventStart.isBefore(snapshotStart) ? eventStart : snapshotStart |
There was a problem hiding this comment.
Isn't this just the min between the two? I mean can't we use dayjs.min here?
There was a problem hiding this comment.
🤔 quite possibly... will loop back if this doesn't fix the issue 🙈
ioannisj
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #26718
which was a follow-up to #26718
this continues to behave differently in production than with fake data locally 🤷
when segmenting we make sure there's a buffer at the end if the recording data ends before the metadata end
and we make sure there's a gap in between segments if they don't touch
let's also make sure there's a gap at the start of the recording if meta start is before snapshot start