fix(ci): Show docker compose logs only when tests don't run #21613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
changed the title
neilkakkar
requested review from
pauldambra and
mariusandra
and removed request for
pauldambra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
.... and store duration artifacts again so we can split tests accurately.
Edit: There seems to be something wonky going on with the splits using the durations file I generated. Will fix this in a follow up by generating it using the ci action (this is chugging along: https://github.com/PostHog/posthog/actions/runs/8726006257/job/23940293619 ) . One test hangs, others finish faster. And sadly, the faster split algo can't be used because of test interdependencies / snapshot interdependencies. Will take a look at this too.
I want to get the first part in anyway because that is getting very annoying.
Max time before:
Max time after: 14 minutes, ... assuming it doesn't hang (some temporal stuff https://github.com/PostHog/posthog/actions/runs/8725338203/job/23938741307 )
and 11 minutes, if I can get tests to be independent.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?