fix: Fix subscriptions sending twice #21581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webjunkie
commented
Apr 16, 2024
Comment on lines
+133
to
+134
| if "update_fields" in kwargs: | ||
| kwargs["update_fields"].append("next_delivery_date") |
There was a problem hiding this comment.
This is now recommended to add in Django 4.2, so doing it here while on it.
mariusandra
approved these changes
Apr 17, 2024
|
Seems like there's a legit test failure: 
|
|
Yes, saw it after all 😅 |
|
yeah a fix for this CI spew is here: #21613 - getting there |
If we create subscriptions in the buffer that we have before the full hour we shouldn't expect them to run right in this hour. This is getting wonky.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Daily subscriptions are sent twice.
Theory: Since they run 5 minutes before the full hour, next delivery date will be scheduled again on same day (one hour later). Only then the
nowis larger then the intended date and next run will be scheduled correctly in a day.Follow up from #21419
Changes
Revert #21419 but add
max()so that we never take a date in the past.Does this work well for both Cloud and self-hosted?
it doesn't have an impact
How did you test this code?