feat(ci): split out temporal, make tests faster #21636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
approved these changes
Apr 18, 2024
posthog/test/test_decorators.py
Outdated
| response = self.client.get(f"/api/dummy").json() | ||
|
|
||
| print(response) # noqa: T201 |
There was a problem hiding this comment.
this is me trying to debug a CI only failure 😓 - still doesn't work
pauldambra
reviewed
Apr 18, 2024
| @@ -144,7 +145,7 @@ runs: | |||
| run: echo "PYTEST_ARGS=--snapshot-update" >> $GITHUB_ENV # We can only update snapshots within the PostHog org | |||
|
|
|||
| # Tests | |||
| - name: Run FOSS tests | |||
| - name: Run FOSS & EE tests | |||
There was a problem hiding this comment.
really we should keep them separate so that someone using the FOSS repo can run the tests
in practice you already can't run the FOSS tests without the EE folder present
so 🙈
There was a problem hiding this comment.
oh darn it, I'll create a separate route for the foss repo, good point thanks!
There was a problem hiding this comment.
oh wait, that second line.... uhmm uhmm
There was a problem hiding this comment.
maybe a future-(Neil|Paul) problem to solve 🙈
|
only failure now is the test failing on master |
Twixes
reviewed
Apr 18, 2024
Twixes
reviewed
Apr 18, 2024
tomasfarias
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following up from #21613 , this makes tests twice as fast faster, with max time down to ~10 mins from ~20 mins, and extracts out temporal tests into its own thing, because there seems to be some strong dependence there causing tests to time out if not run together (? - didn't investigate this deeply).
It combines foss and ee, because ee were running much more quickly, and doesn't seem like there's any reason to keep them separate now.
But the other advantage of going this route is we don't need to wait for temporal in regular tests, making them faster.
Should be more robust, and the tests do seem to be more evenly distributed. Will consider making the durations update more seamless, to make this easy to update and keep in sync
One thing to be cautious of is whether this makes flopping snapshots more prevalent. If yes, I'd argue that is a problem with tests we should fix (since they depend on order they run in), and try to keep this optimisation in. I've fixed some of these but not sure if new ones will prop up.
Lastly there's this one damn test https://github.com/PostHog/posthog/blob/master/posthog/test/test_decorators.py#L29 which I have no idea why its failing. I will skip this test 🙈 - unless you have any ideas what might be going wrong here?
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?