fix(batch-exports): drop internal inserted_at column from s3 exports #21191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
brett/drop-s3-inserted-at
branch
from
1da21fe to
130a9b8
Compare
bretthoerner
force-pushed
the
brett/drop-s3-inserted-at
branch
from
130a9b8 to
4a4088f
Compare
bretthoerner
force-pushed
the
brett/drop-s3-inserted-at
branch
from
4a4088f to
140652c
Compare
xvello
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is an internal column, and some users don't want accurate timestamps (plus it's just confusing).
Changes
Drop it from S3 exports.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Existing.