Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch-exports): drop internal inserted_at column from s3 exports #21191

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(batch-exports): drop internal inserted_at column from s3 exports #21191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions posthog/temporal/batch_exports/s3_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,6 @@ def s3_default_fields() -> list[BatchExportField]:
batch_export_fields.append({"expression": "elements_chain", "alias": "elements_chain"})
batch_export_fields.append({"expression": "nullIf(person_properties, '')", "alias": "person_properties"})
batch_export_fields.append({"expression": "toString(person_id)", "alias": "person_id"})
# In contrast to other destinations, we do export this field.
batch_export_fields.append({"expression": "COALESCE(inserted_at, _timestamp)", "alias": "inserted_at"})

# Again, in contrast to other destinations, and for historical reasons, we do not include these fields.
not_exported_by_default = {"team_id", "set", "set_once"}
Expand Down
1 change: 0 additions & 1 deletion posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ async def assert_clickhouse_records_in_s3(
{
"fields": [
{"expression": "event", "alias": "my_event_name"},
{"expression": "inserted_at", "alias": "inserted_at"},
{"expression": "1 + 1", "alias": "two"},
],
"values": {},
Expand Down
Loading