Skip to content

Commit

Permalink
fix(batch-exports): drop internal inserted_at column from s3 exports (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
bretthoerner authored Mar 28, 2024
1 parent 617dc39 commit 29f8c26
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions posthog/temporal/batch_exports/s3_batch_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,6 @@ def s3_default_fields() -> list[BatchExportField]:
batch_export_fields.append({"expression": "elements_chain", "alias": "elements_chain"})
batch_export_fields.append({"expression": "nullIf(person_properties, '')", "alias": "person_properties"})
batch_export_fields.append({"expression": "toString(person_id)", "alias": "person_id"})
# In contrast to other destinations, we do export this field.
batch_export_fields.append({"expression": "COALESCE(inserted_at, _timestamp)", "alias": "inserted_at"})

# Again, in contrast to other destinations, and for historical reasons, we do not include these fields.
not_exported_by_default = {"team_id", "set", "set_once"}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ async def assert_clickhouse_records_in_s3(
{
"fields": [
{"expression": "event", "alias": "my_event_name"},
{"expression": "inserted_at", "alias": "inserted_at"},
{"expression": "1 + 1", "alias": "two"},
],
"values": {},
Expand Down

0 comments on commit 29f8c26

Please sign in to comment.