Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query-nodes): camel case retention filter #19800

Merged
merged 14 commits into from
Jan 19, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jan 16, 2024

Problem

We want to clean up our query schema. See also #19541.

Changes

This PR camel cases all retentionFilter properties.

  • retention_reference
  • retention_type
  • returning_entity
  • target_entity
  • total_intervals

How did you test this code?

Verified setting, saving and loading an insight with this filter works

@thmsobrmlr thmsobrmlr force-pushed the camel-case-paths-filter branch from f0d3a7a to 1e6b129 Compare January 17, 2024 16:16
@thmsobrmlr thmsobrmlr force-pushed the camel-case-retention-filter branch from 67c6f68 to 142c125 Compare January 17, 2024 16:33
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my brief look. However testing locally, I experienced the CSS bug again. Probably not up to date with master.

image

@thmsobrmlr thmsobrmlr force-pushed the camel-case-paths-filter branch from 1e6b129 to 73550ae Compare January 19, 2024 11:59
@thmsobrmlr
Copy link
Contributor Author

Looks good from my brief look. However testing locally, I experienced the CSS bug again. Probably not up to date with master.

image

Yep, this is branched off from another refactor that was done before the css fixes in master.

Base automatically changed from camel-case-paths-filter to master January 19, 2024 12:40
@thmsobrmlr thmsobrmlr force-pushed the camel-case-retention-filter branch from e47f95d to 37335da Compare January 19, 2024 13:25
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) January 19, 2024 13:28
@thmsobrmlr thmsobrmlr merged commit bbfebce into master Jan 19, 2024
99 checks passed
@thmsobrmlr thmsobrmlr deleted the camel-case-retention-filter branch January 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants