Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retention): limit series query cache #19847

Closed
wants to merge 3 commits into from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jan 18, 2024

Problem

See https://posthoghelp.zendesk.com/agent/tickets/9449

Changes

This PR limits the amount of entries in the query cache for series to the current amount of entries when getting them from a retention filter.

There is another issue where the retention entities won't be set from cached series. I'll implement a fix after #19800 is in.

How did you test this code?

Navigated between insight types

@thmsobrmlr thmsobrmlr marked this pull request as ready for review January 18, 2024 17:27
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@thmsobrmlr thmsobrmlr closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant