Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): deactivate series cache for retention and lifecycle insights #19851

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

thmsobrmlr
Copy link
Contributor

Problem

See this Slack thread https://posthog.slack.com/archives/C0368RPHLQH/p1705587408655359

Changes

This PR temporarily deactivates the query cache for series for retention and lifecycle insights. A proper fix needs untangling of the RetentionEntity type, which currently has both a type and a kind. I'd like to do that after #19800 is in.

How did you test this code?

Navigating between insight types

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@mariusandra mariusandra merged commit 6c970a7 into master Jan 19, 2024
98 checks passed
@mariusandra mariusandra deleted the fix-query-cache-tmp branch January 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants