feat: Toolbar 3000 changes #18671
feat: Toolbar 3000 changes #18671
Conversation
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated9 snapshot changes in total. 0 added, 9 modified, 0 deleted:
Triggered by this commit. |
…g into feat/toolbar-3000-changes
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -30.4 kB (-2%) Total Size: 1.96 MB
|
There was a problem hiding this comment.
┻┳|
┻┳|
┳┻|
┳┻|
┻┳|
┻┳|
┳┻|
┳┻|
┻┳|
┳┻|
┻┳|
┳┻| _
┻┳| •.•) [I'm hiding off-screen]
┳┻|⊂ﾉ
┻┳|
| @@ -65,8 +65,8 @@ export const toolbarLogic = kea<toolbarLogicType>([ | |||
| }, | |||
| processUserIntent: async () => { | |||
| if (props.userIntent === 'add-action' || props.userIntent === 'edit-action') { | |||
There was a problem hiding this comment.
Yeah, I don't know how you would launch the toolbar and edit an action at the same time. I vote to delete it and then add it back if someone can tell us what broke
There was a problem hiding this comment.
Feels good. One tiny nit is that the scaling transition when dragging feels like it could be sped up a bit to me, certainly after dropping (I have less of an opinion on drag start). Kind of falls under this thinking for me https://posthog.slack.com/archives/C064U4XCPHQ/p1699987726918269
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
Problem
Following up on Paul's great work with some tweaks and changes that I believe polish it off
Changes
TODO
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?