Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toolbar 3000 #17276

Merged
merged 305 commits into from
Nov 23, 2023
Merged

feat: toolbar 3000 #17276

merged 305 commits into from
Nov 23, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Aug 31, 2023

Toolbar, but 3000

Needs #18794 (probably)

2023-11-16 17 13 15

TODO

  • Update docs around toolbar to match new styles
  • Make sure it still opens the authorize page

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra marked this pull request as ready for review September 4, 2023 11:22
@pauldambra pauldambra requested review from a team and corywatilo September 4, 2023 11:22
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra
Copy link
Member Author

Dangnammit a recent change in this PR broke the hedgehog buddy :'(

2023-09-04 12 37 25

Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start for this! Always exciting to see things get a new lick of paint 🎨

I reviewed the code and all seemed reasonable but maybe a little difficult to fully understand because a lot of it is CSS changes. Played around with it locally and took screenshots of what I noticed as I went:

  1. The feature flag list item seemed to have the wrong colour when disabled in dark mode
Screenshot 2023-09-05 at 10 43 50
  1. There are different border radius & possibly shadow on the toolbar between light and dark mode
Screenshot 2023-09-05 at 10 42 45 Screenshot 2023-09-05 at 10 42 34
  1. The search bar is only half visible when you open the feature flags tab directly. If you open it when the target menu is open it appears as expected
    https://github.com/PostHog/posthog/assets/6685876/53d6cd3a-14a0-4c81-8746-8d5519e0bdf4

  2. Possibly a personal preference but I wonder if the toolbar icons should have some top and bottom padding

Screenshot 2023-09-05 at 10 38 31
  1. The toolbar menu seems to flex to the full height of the page
    https://github.com/PostHog/posthog/assets/6685876/e7ec03c9-b210-4f93-8d73-55e5231ad4c0

  2. Hovering over elements in the list seem to highlight random parts of the page (possibly not a 3000 issue)
    https://github.com/PostHog/posthog/assets/6685876/bd4fa8de-b958-46c5-a483-1f09104210c4

  3. Scrolling when your mouse is on the toolbar will scroll the whole body of the page

scroll.mp4

frontend/src/toolbar/button/toolbarButtonLogic.ts Outdated Show resolved Hide resolved
@pauldambra
Copy link
Member Author

pauldambra commented Sep 5, 2023

  1. The feature flag list item seemed to have the wrong colour when disabled in dark mode
    • ✅. overridden to a highlight color
  2. There are different border radius & possibly shadow on the toolbar between light and dark mode
    • 🦆 in wat mode
  3. The search bar is only half visible when you open the feature flags tab directly. If you open it when the target menu is open it appears as expected
    • 🦆 in wat mode
  4. Possibly a personal preference but I wonder if the toolbar icons should have some top and bottom padding
    • ✅. made square
  5. The toolbar menu seems to flex to the full height of the page
    • ✅. -> set a max height
    • 👁️ detect if space above too small and show below instead
  6. Hovering over elements in the list seem to highlight random parts of the page (possibly not a 3000 issue)
    • ✅. -> actually just a design issue... (how can|do) we make this clearer?
  7. Scrolling when your mouse is on the toolbar will scroll the whole body of the page
    • 👁️ . -> is that just app.posthog?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra
Copy link
Member Author

  • if you're not interacting with it, then it shrinks to just the logo so it's not in the way
  • make the whole thing draggable (the whole background?)
  • peek can open without needing a button at the end
  • menu should close when click away

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

15 snapshot changes in total. 0 added, 15 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

7 snapshot changes in total. 0 added, 7 modified, 0 deleted:

  • chromium: 0 added, 7 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i finally fixed the issue!

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@PostHog PostHog deleted a comment from posthog-bot Nov 23, 2023
@benjackwhite benjackwhite merged commit 3cb9ed4 into master Nov 23, 2023
74 checks passed
@benjackwhite benjackwhite deleted the feat/toolbar-3000 branch November 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar 3000